ci: build windows pypi wheels (with conda) #558
Conversation
b85db24 to
3737fb1
Compare
3737fb1 to
7578a85
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 58.40% 58.40%
=======================================
Files 62 62
Lines 6433 6433
Branches 1150 1150
=======================================
Hits 3757 3757
Misses 2385 2385
Partials 291 291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Hi @trim21
Thank you very much for your PR.
I think that this solution using Conda to install udunits2 is probably more robust than building it in the workflow as you proposed in #556. This way, the udunits2 version is free to update rather than being pinned to a version in the ci-wheels.yml file.
I only have one small suggested change with respect to the Windows specific test command, which I will leave to your discretion.
Otherwise I've updated your PR with the latest changes from main and I think we're all good to go on this one. 👍
Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com>
|
My pr can't trigger testing unless manually approved by maintainers , I'm not sure if the suggestion work |
Fixed quoting for windows
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
OK. This is all working now.
Apologies for the several iterations to fix the CIBW_TEST_COMMAND_WINDOWS value - got there eventually. 🙄
Thanks for the contribution. 🚀
Merge `CIBW_TEST_COMMAND` and `CIBW_TEST_COMMAND_WINDOWS`
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
OK. Everything is building ok and all tests are running and passing.
Thanks for your patience on this @trim21 - that was much more of a chore sorting out the windows multi-line command than I expected. LGTM.
|
It may be a bad idea to use dll from conda env. I have a similar PR on other project use c/c++ package from conda env to build a pypi wheel, which cause a segfault on certain case, and we recently reverted it to use a manually build. |
🚀 Pull Request
Description
almost same patch with #556 , but install udunits from conda