Skip to content

Conversation

@trim21
Copy link
Contributor

@trim21 trim21 commented Feb 13, 2025

🚀 Pull Request

Description

build pypi wheel for windows

reason:

https://github.com/SciTools/iris depend on this, which has a pypi windows wheel.

how:

  • install libexpat from vcpkg
  • install udunits from source with cmake + vcpkg

old CIBW_TEST_COMMAND failed with reason I don't understand, looks like some kind of shell problem... So I only run pytest on windows.


Also another PR to install udunits from conda, if maintainers prefer #558

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

@trim21 trim21 marked this pull request as ready for review February 13, 2025 02:39
@ukmo-ccbunney
Copy link
Contributor

Hi @trim21
Thanks for raising this PR. 🚀
I think your alternative PR #558 using conda is a better solution to this as it avoids pinning the udunits2 version in the ci-wheels.yml file.

@trim21
Copy link
Contributor Author

trim21 commented Mar 21, 2025

ok

@trim21 trim21 closed this Mar 21, 2025
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants