Merged
Conversation
🦋 Changeset detectedLatest commit: e37dd32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Schniz
reviewed
Jul 3, 2023
Owner
Schniz
left a comment
There was a problem hiding this comment.
all value and ship?
| "fish" => Ok(Box::from(super::fish::Fish)), | ||
| "powershell" => Ok(Box::from(super::powershell::PowerShell)), | ||
| shell_type => Err(format!("I don't know the shell type of {shell_type:?}",)), | ||
| impl From<Shells> for Box<dyn Shell> { |
Owner
There was a problem hiding this comment.
This is a first good step, in a later PR we can remove Box<dyn Shell> entirely by implementing Shell for Shells and forward the calls
This reverts commit 7781b5d.
Merged
quixoten
added a commit
to quixoten/fnm
that referenced
this pull request
Jul 15, 2023
as far as i can tell, this was broken by the clap upgrade (Schniz#991).
quixoten
added a commit
to quixoten/fnm
that referenced
this pull request
Aug 3, 2023
as far as i can tell, this was broken by the clap upgrade (Schniz#991).
Schniz
added a commit
that referenced
this pull request
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #823, and adjusted breaking-changes.
Mostly drop
possible_valuesin favor of usingenums derivingValueEnum.