Update Claude Code settings schema for v2.1.29 with hostPattern/async and test coverage#5332
Conversation
|
Thanks for the PR! This section of the codebase is owned by @domdomegg and @bogini - if they write a comment saying "LGTM" then it will be merged. |
|
Thanks |
Thanks so much for merging my PR! Really appreciate your time reviewing it. Big respect to you and all the committers for keeping this project alive — I know it takes a ton of effort. Cheers! |
Removed duplicate allowAllUnixSockets, allowedDomains, and spinnerVerbs keys that were introduced during merge. Kept upstream versions from PR SchemaStore#5332. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| "type": "string", | ||
| "description": "Tool permission rule. See https://code.claude.com/docs/en/settings#permission-rule-syntax", | ||
| "pattern": "^((Bash|Edit|ExitPlanMode|Glob|Grep|KillShell|NotebookEdit|Read|Skill|Task|TodoWrite|WebFetch|WebSearch|Write)(\\((?=.*[^)*?])[^)]+\\))?|mcp__.*)$", | ||
| "pattern": "^((Bash|Edit|ExitPlanMode|Glob|Grep|KillShell|LS|MultiEdit|NotebookEdit|NotebookRead|Read|Skill|SlashCommand|Task|TodoWrite|WebFetch|WebSearch|Write)(\\((?=.*[^)*?])[^)]+\\))?|mcp__.*)$", |
There was a problem hiding this comment.
@kanghyojun @hyperupcall @domdomegg I had removed SlashCommand from this regex in #5300 . As per my understanding, after the new behavior of treating commands as skills, SlashCommand tool permission requests are not going to be sought.
The only reason to retain it could be to cover the use case of someone consciously using much older versions, which still used the SlashCommand tool. However, it's been a long time since the change from SlashCommand to Skill. So I am wondering whether there is merit to retain it.
There was a problem hiding this comment.
Miteshashar is right — SlashCommand was renamed to Skill as a tool name back in October 2025. A SlashCommand(...) permission rule would be silently ignored since no tool has that name anymore. Fine to drop it.
- Add prefersReducedMotion (boolean) — accessibility setting for UI animations (v2.1.30) - Add effortLevel (low/medium/high) — Opus 4.6 adaptive reasoning control (v2.1.31) - Add teammateMode (auto/in-process/tmux) — agent teams display mode (v2.1.32) - Add allowManagedPermissionRulesOnly (boolean) — enterprise managed settings companion to allowManagedHooksOnly - Add TeammateIdle and TaskCompleted hook events — agent teams quality gates (v2.1.33) - Add agent hook handler type with multi-turn tool access for verification hooks (v2.1.33) - Add model property to prompt and agent hook types - Expand defaultMode enum with delegate (agent teams) and dontAsk modes, add per-mode descriptions - Remove SlashCommand from permissionRule pattern and examples — renamed to Skill since Oct 2025, per SchemaStore#5332 discussion - Add TaskOutput to permissionRule pattern — undocumented but functional tool permission - Fix deprecated :* suffix syntax in permission examples to space-star format - Fix Read absolute path example to use // prefix - Add Task(Explore) and mcp__puppeteer permission rule examples - Fix broken permissions link (iam 404 → permissions + settings) - Mark Setup hook as UNDOCUMENTED — not in lifecycle table at docs/en/hooks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added schema support
Tests
Updated and added Claude Code settings fixtures to cover new behavior.
Positive tests
Negative tests
Upstream references (Claude Code)