Fix for #13: Allow Extensions deployment from additional folders#14
Merged
Fix for #13: Allow Extensions deployment from additional folders#14
Conversation
- Replaced simple slash prefix check with `filepath.IsAbs()` to properly block absolute paths across platforms. - Used `filepath.ToSlash()` to ensure Windows path separators are correctly normalized for the container execution path.
- Removed bold styling from printer prefixes (Info, Success, Warn, Error, Debug). - Introduced `SpacedSpinner` to ensure consistent trailing newline spacing without relying on pterm's implicit newlines.
Addresses the following review feedback: - Corrected `env dash` documentation and `--config-file` flag in USAGE.md - Used absolute container path for publish pubfile and handled non-NotExist stat errors in pkg/builder/publish.go - Added `ok` check for `runtime.Caller()` in gen-docs/main.go - Moved success message to `pre-commit` target in Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ui): improve printer styling and add custom spaced spinner
SpacedSpinnerto ensure consistent trailing newline spacing without relying on pterm's implicit newlines.docs: regenerate docs
fix(builder): handle absolute and Windows paths in contract publication
filepath.IsAbs()to properly block absolute paths across platforms.filepath.ToSlash()to ensure Windows path separators are correctly normalized for the container execution path.Resolves #13