Remove some big files from the distributions#3482
Merged
krzywon merged 3 commits intoSasView:mainfrom Dec 17, 2025
Merged
Conversation
8969a6c to
de0e8cc
Compare
Contributor
Author
|
rebased and pointed at |
983a999 to
e9e8cb5
Compare
Switch links to point to github files instead
Icon file contains 1024x1024 PNG but is only a 256x256 icon, so shrink it down to that size and also optimise the PNG compression And yes, there are 4 duplicate copies of the icon in the git repository
e9e8cb5 to
e530a63
Compare
Contributor
|
Fundamentally, the files removed here are not needed in the release, so I agree this is ready. I'll test the wheel in a clean environment when I get an opportunity. |
krzywon
approved these changes
Dec 17, 2025
Contributor
krzywon
left a comment
There was a problem hiding this comment.
Tested the wheel in a clean environment. No issues. My only question is the removal of the five files from example_data\coordinate_data . @dehoni - is it okay to remove mag_cylinder.sld and all four of the sphere_R=*.vtk files?
Contributor
|
Hi Jeff,
the data can and have been generated with Python as described in the generic scattering calculator tutorial: https://www.sasview.org/docs/_downloads/f51d0b23eecb99c7d84e72df4f27d7c3/sphere_R%3D0_0025.vtk .
instead of carrying them around in the distrbution.
Cheers
Dirk
Dirk Honecker ***@***.******@***.***>
ISIS Pulsed Neutron and Muon Source
STFC Rutherford Appleton Laboratory | Harwell Campus
Office R3 1.41 | Didcot | OX11 0QX | United Kingdom
Mobile: +44 7738 260880 | Tel: +44 1235 567112
…________________________________
From: Jeff Krzywon ***@***.***>
Sent: 17 December 2025 2:43 PM
To: SasView/sasview ***@***.***>
Cc: Honecker, Dirk (STFC,RAL,ISIS) ***@***.***>; Mention ***@***.***>
Subject: Re: [SasView/sasview] Remove some big files from the distributions (PR #3482)
@krzywon approved this pull request.
Tested the wheel in a clean environment. No issues. My only question is the removal of the five files from example_data\coordinate_data . @dehoni<https://github.com/dehoni> - is it okay to remove mag_cylinder.sld and all four of the sphere_R=*.vtk files?
—
Reply to this email directly, view it on GitHub<#3482 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFLXMH5SZAR7FQUMBJKN5F34CFTYJAVCNFSM6AAAAACAKO5GL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOBYGA4DGMZQGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #3481
Wheel size is down to about 111 MB with these changes... getting closer.
Works towards fixing #3481
How Has This Been Tested?
Only looking at wheel sizes - tests to look for broken links in docs and UI need to be done still
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licencing (untick if necessary)