Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 55.24% 55.24%
=======================================
Files 219 219
Lines 13286 13286
Branches 1445 1445
=======================================
Hits 7340 7340
Misses 5631 5631
Partials 315 315 ☔ View full report in Codecov by Sentry. |
dbuechel
approved these changes
Nov 24, 2023
Member
dbuechel
left a comment
There was a problem hiding this comment.
Excellent, thanks a lot for your contribution!
dbuechel
added a commit
that referenced
this pull request
Nov 24, 2023
Member
|
Please note that the language of SEB is chosen according to the language of the operating system, and if there is no translation for a particular language, the English translation will be used. |
dbuechel
added a commit
that referenced
this pull request
Nov 24, 2023
Member
|
You can now test the translation in the latest beta build: https://sebdev-let.ethz.ch/project/AppVeyor/seb-win-refactoring/builds/746 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added russian ru.xml file. I understand that all texts in app are in .xml files in all languages. So i took en.xml and translated it to russian, saved all keys and %%vars%% as it was. I also think, you'lI add language change button by yourself, cause I'm not sure I can do this myself. hope you'll add it in one of becoming updates <3.
P.S. If smth is wrong i'll fix it and commit.