Proof-of-concept desktop keyboard navigation#278
Proof-of-concept desktop keyboard navigation#278dbuechel merged 20 commits intoSafeExamBrowser:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 58.91% 58.59% -0.33%
==========================================
Files 271 272 +1
Lines 12176 12257 +81
Branches 1262 1274 +12
==========================================
+ Hits 7174 7182 +8
- Misses 4716 4786 +70
- Partials 286 289 +3
Continue to review full report at Codecov.
|
dbuechel
left a comment
There was a problem hiding this comment.
Great work, thanks a lot @yolpsoftware! There unfortunately were some changes which are causing merge conflicts, so it'd be great if you could resolve these. Furthermore, if you'd have the time then it would be awesome if you could also translate all the new text into the other three languages (using Google Translate).
SafeExamBrowser.Browser.Contracts/SafeExamBrowser.Browser.Contracts.csproj
Outdated
Show resolved
Hide resolved
SafeExamBrowser.UserInterface.Desktop/Windows/BrowserWindow.xaml.cs
Outdated
Show resolved
Hide resolved
(cherry picked from commit 2b6c2f0ecaa8953ae7f126b562e58b87f98d6d3f)
|
Thanks a lot for the quick fixes @yolpsoftware. There are only 3 minor things left, once resolved I'll immediately approve and merge the pull request. Great work indeed 👍 |
|
Had to adapt some code to the changes introduced by 7142380#diff-86bb6b5aa3ce5d57bf4a50c8682d6b4dbb47f45b4b69499e758ea166d571093e. |
dbuechel
left a comment
There was a problem hiding this comment.
Excellent, thanks for the quick fixes. Looks all good to me now 👍
These changes allow the user to navigate through the browser using Tab and Shift-Tab.