🦙 MegaLinter status: ✅ SUCCESS

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

Codecov Report

Attention: Patch coverage is 99.25373% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.21%. Comparing base (27659ee) to head (faadddd).

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   98.82%   99.21%   +0.39%     
==========================================
  Files          25       25              
  Lines        2120     2176      +56     
==========================================
+ Hits         2095     2159      +64     
+ Misses         25       17       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann Nevermind, your request regarding the package names still does not work according to your requirements. I thought that, for example, a module path/to/module which is exported in the path/to/__init__.py file like from path.to import module would get the stub text package path.to (only in this such a case). But according to you the package information is dependent on the class that is reexported in the __init__.py file, right? So if we have from path.to.module import SomeClass in the __init__.py instead of the first import I named, would we still get the stub text package path.to? And what if we have other public classes in the module that are not imported in the __init__ file?

But I'd say we close this PR first anyway, since the file changes are, once again, too much for a "quick" review.

So, after todays meeting there seemed to be a problem with these stubs. How would the stubs for the infer_alias_2 = AliasA part look like?

from data.modules import ClassA as AliasA

class ClassB:
   ...

alias_b = ClassB

class AliasingModuleClassC():
   typed_alias: alias_b
   infer_alias = alias_b()
   typed_alias_2: AliasA
   infer_alias_2 = AliasA

@PythonModule("data.modules.aliasing_module_1")
package data.modules.aliasingModule1

from data.modules import ClassA

class ClassB()

class AliasingModuleClassC() {
    @PythonName("typed_alias")
    static attr typedAlias: ClassB
    @PythonName("infer_alias")
    static attr inferAlias: ClassB
    @PythonName("typed_alias_2")
    static attr typedAlias2: ClassA
    @PythonName("infer_alias_2")
    static attr inferAlias2: ClassA
}

@lars-reimann Nevermind, your request regarding the package names still does not work according to your requirements. I thought that, for example, a module path/to/module which is exported in the path/to/__init__.py file like from path.to import module would get the stub text package path.to (only in this such a case). But according to you the package information is dependent on the class that is reexported in the __init__.py file, right? So if we have from path.to.module import SomeClass in the __init__.py instead of the first import I named, would we still get the stub text package path.to? And what if we have other public classes in the module that are not imported in the __init__ file?

Ask yourself how you can import a class/global function from a library into your Python code. There might be multiple ways to do so, if they get reexported in __init__.py files. Out of the possible ways, pick the public module path that is

1. a subpath of the path to the module that declares the class/global function (if possible),
2. the shortest possible one.

Then use that as the Safe-DS package name (after conversion to name convention).

Example:

# pack/_test.py

class MyClass

# pack/__init__.py

from ._test import MyClass

# Client code

from pack._test import MyClass # Legal, but not OK, since internal module
from pack import MyClass # OK

Resulting Safe-DS code:

package pack

class MyClass()

So, after todays meeting there seemed to be a problem with these stubs. How would the stubs for the infer_alias_2 = AliasA part look like?

from data.modules import ClassA as AliasA
class AliasingModuleClassC():
   infer_alias_2 = AliasA

We cannot represent the type of infer_alias_2 in the stubs, since we don't have a use case for reflection. Just omit the type and put a TODO above that line.

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

• v0.2.0
• GitHub release

Your semantic-release bot 📦🚀