This repository was archived by the owner on Nov 23, 2024. It is now read-only.
feat: extraction of boundary types from various docstrings#111
Merged
lars-reimann merged 21 commits intomainfrom May 5, 2023
Merged
Conversation
Added some new rules It is now possible to extract multiple boundaries.
Minimal refactoring was done. Some test cases were added.
Some test cases were added.
Member
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
…ontain-boundary-type
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 90.08% 90.40% +0.31%
==========================================
Files 82 83 +1
Lines 4084 4334 +250
==========================================
+ Hits 3679 3918 +239
- Misses 405 416 +11
|
…rings-that-contain-boundary-type' into 48-extraction-from-various-docstrings-that-contain-boundary-type
Contributor
Author
|
@lars-reimann |
Member
|
@nvollroth Add a comment |
Return type of the create function is now BoundaryType. Added one new pattern + test case. Corrected the error suppression for ruff.
…ontain-boundary-type
Member
|
@nvollroth The lint check passes now. |
…ontain-boundary-type
lars-reimann
suggested changes
May 4, 2023
…rings-that-contain-boundary-type' into 48-extraction-from-various-docstrings-that-contain-boundary-type
Added 1 Testcase
Added some Testcases
Contributor
Author
|
@lars-reimann |
lars-reimann
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48, closes #36, closes #35, closes #32, closes #31, closes #30, closes #27, closes #8.
Summary of Changes
SpaCy rules were generated to recognize named examples and extract the resulting boundaries.
Instructions for Manual Testing (if required)
pytestfortest_extract_boundary_values.py.pytest.