Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

Boundary annotation can't deal with parameters with more than one allowed datatype #36

@GideonKoenig

Description

@GideonKoenig

Describe the bug

Currently there are for example parameters of type (int, float, none), that have a interval specified for if the value is a float, but not, if it's a int.

To Reproduce

#/sklearn/sklearn.ensemble._forest/RandomForestClassifier/__init__/max_samples
Here a boundary annotations is automatically generated, even though the interval is only valid for floats.

Expected behavior

A boundary annotation should be defined for a specific datatype and should only be applied if the provided value is of that type. This way you can have multiple boundaries for different datatypes like float and int and also allow for none or any other type to exist as possible parameter value type next to the one, the boundary applies to.

Screenshots (optional)

Screenshot from 2022-06-24 16-29-48

Additional Context (optional)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    @boundaryRelated to the @boundary annotationenhancement 💡New feature or requestmissing annotationAn annotation should have been generated automatically but wasn'twrong annotationAn annotation was generated automatically but is incorrect

    Type

    No type

    Projects

    Status

    ✔️ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions