Skip to content

feat: hyperparameter optimization for RNNs and CNNs#923

Merged
sibre28 merged 27 commits intomainfrom
912-hyperparamteroptimization-for-rnns-and-cnns
Aug 28, 2024
Merged

feat: hyperparameter optimization for RNNs and CNNs#923
sibre28 merged 27 commits intomainfrom
912-hyperparamteroptimization-for-rnns-and-cnns

Conversation

@sibre28
Copy link
Copy Markdown
Contributor

@sibre28 sibre28 commented Aug 16, 2024 •
edited
Loading

Closes #912

Summary of Changes

New Features:

  • fit_by_exhaustive_search now also works for RNNs and CNNs
  • ClassificationMetrics and RegressionMetrics now also work for TimeSeriesDatasets, even when the predictions are of type list.
  • Raise Error when classifing time series data with continuous = True, as we dont currently support this use-case (since both classification and continuous predictions require the amount of neurons in the last layer to be set differently, according to either the number of classes or the number of values to predict; The output would have to be 2-dimensional)

@sibre28 sibre28 linked an issue Aug 16, 2024 that may be closed by this pull request
Hyperparamteroptimization for RNNs and CNNs #912
Closed
@sibre28 sibre28 marked this pull request as draft August 16, 2024 00:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 1.67s
✅ PYTHON mypy 5 0 3.62s
✅ PYTHON ruff 5 0 0 0.36s
✅ REPOSITORY git_diff yes no 0.35s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.26740% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.17%. Comparing base (ccb60c3) to head (76b78ca).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/safeds/ml/nn/_model.py 99.11% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   98.14%   98.17%   +0.03%     
==========================================
  Files         122      122              
  Lines        6958     7183     +225     
==========================================
+ Hits         6829     7052     +223     
- Misses        129      131       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sibre28 and others added 18 commits August 16, 2024 03:16
@sibre28 sibre28 marked this pull request as ready for review August 20, 2024 01:09
@sibre28 sibre28 merged commit b1e8933 into main Aug 28, 2024
@sibre28 sibre28 deleted the 912-hyperparamteroptimization-for-rnns-and-cnns branch August 28, 2024 17:18
@lars-reimann lars-reimann changed the title feat: hyperparamteroptimization for rnns and cnns feat: hyperparameter optimization for RNNs and CNNs Sep 17, 2024
lars-reimann pushed a commit that referenced this pull request Sep 17, 2024
@semantic-release-bot
chore(release): 0.28.0 [skip ci]
3aed2fe 
## [0.28.0](v0.27.0...v0.28.0) (2024-09-17)

### Features

* hyperparameter optimization for classical models ([#843](#843)) ([d8f7491](d8f7491)), closes [#264](#264)
* hyperparamteroptimization for rnns and cnns ([#923](#923)) ([b1e8933](b1e8933)), closes [#912](#912)
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Sep 17, 2024

🎉 This PR is included in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lars-reimann lars-reimann Awaiting requested review from lars-reimann lars-reimann is a code owner

@Marsmaennchen221 Marsmaennchen221 Awaiting requested review from Marsmaennchen221

1 more reviewer

@Gerhardsa0 Gerhardsa0 Gerhardsa0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hyperparamteroptimization for RNNs and CNNs

4 participants

@sibre28 @lars-reimann @Gerhardsa0 @megalinter-bot