feat: optionally pass type to column#79
Merged
lars-reimann merged 4 commits intomainfrom Mar 25, 2023
Merged
Conversation
Member
Author
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.02%
==========================================
Files 42 42
Lines 1156 1154 -2
==========================================
- Hits 1060 1058 -2
Misses 96 96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lars-reimann
pushed a commit
that referenced
this pull request
Mar 26, 2023
## [0.4.0](v0.3.0...v0.4.0) (2023-03-26) ### Features * better names for properties of `TaggedTable` ([#74](#74)) ([fee398b](fee398b)) * change the name of a `Column` ([#76](#76)) ([ec539eb](ec539eb)) * metrics as methods of models ([#77](#77)) ([bc63693](bc63693)), closes [#64](#64) * optionally pass type to column ([#79](#79)) ([64aa429](64aa429)), closes [#78](#78) * remove `target_name` parameter of `predict` ([#70](#70)) ([b513454](b513454)), closes [#9](#9) * rename `tagged_table` parameter of `fit` to `training_set` ([#71](#71)) ([8655521](8655521)) * return `TaggedTable` from `predict` ([#73](#73)) ([5d5f5a6](5d5f5a6))
Member
Author
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78.
Summary of Changes
For the sake of consistency it is now possible to pass the type of a
Columnin the constructor. This also improves performance, for example when we callget_columnon aTable. In that case we already know the type of the column anyway, so there's no reason to infer it again.