Skip to content

feat: add _file suffix to methods interacting with files#103

Merged
lars-reimann merged 4 commits intomainfrom
file_suffix
Mar 27, 2023
Merged

feat: add _file suffix to methods interacting with files#103
lars-reimann merged 4 commits intomainfrom
file_suffix

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Mar 27, 2023

Summary of Changes

In Table:

  • Rename to_csv to to_csv_file
  • Rename to_json to to_json_file
  • Rename from_csv to from_csv_file
  • Rename from_json to from_json_file
  • Rename path_to_file parameters to path

@lars-reimann lars-reimann requested a review from a team as a code owner March 27, 2023 18:30
@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Mar 27, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 1 0 0 0.82s
✅ JSON jsonlint 1 0 0.19s
✅ JSON npm-package-json-lint yes no 0.42s
✅ JSON prettier 1 0 0 0.42s
✅ JSON v8r 1 0 1.44s
✅ PYTHON black 39 0 0 1.02s
✅ PYTHON flake8 39 0 0.7s
✅ PYTHON isort 39 0 0 0.3s
✅ PYTHON mypy 39 0 1.96s
✅ PYTHON pylint 39 0 3.84s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (7bad2e3) to head (9d13930).
Report is 511 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   92.10%   92.04%   -0.06%     
==========================================
  Files          36       36              
  Lines        1228     1219       -9     
==========================================
- Hits         1131     1122       -9     
  Misses         97       97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit ec011e4 into main Mar 27, 2023
@lars-reimann lars-reimann deleted the file_suffix branch March 27, 2023 18:36
lars-reimann pushed a commit that referenced this pull request Mar 29, 2023
@semantic-release-bot
chore(release): 0.7.0 [skip ci]
07b3062 
## [0.7.0](v0.6.0...v0.7.0) (2023-03-29)

### Features

* `sort_rows` of a `Table` ([#104](#104)) ([20aaf5e](20aaf5e)), closes [#14](#14)
* add `_file` suffix to methods interacting with files ([#103](#103)) ([ec011e4](ec011e4))
* improve transformers for tabular data ([#108](#108)) ([b18a06d](b18a06d)), closes [#61](#61) [#90](#90)
* remove `OrdinalEncoder` ([#107](#107)) ([b92bba5](b92bba5)), closes [#61](#61)
* specify features and target when creating a `TaggedTable` ([#114](#114)) ([95e1fc7](95e1fc7)), closes [#27](#27)
* swap `name` and `data` parameters of `Column` ([#105](#105)) ([c2f8da5](c2f8da5))
@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Mar 29, 2023

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lars-reimann