Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

feat: added MNIST, Fashion-MNIST and KMNIST datasets#164

Merged
lars-reimann merged 18 commits intomainfrom
add-mnist-datasets
Jul 12, 2024
Merged

feat: added MNIST, Fashion-MNIST and KMNIST datasets#164
lars-reimann merged 18 commits intomainfrom
add-mnist-datasets

Conversation

@Marsmaennchen221
Copy link
Copy Markdown
Contributor

@Marsmaennchen221 Marsmaennchen221 commented May 8, 2024 •
edited
Loading

Closes #161
Closes #162
Closes #163

Summary of Changes

feat: added MNIST, Fashion-MNIST and KMNIST datasets
build: bump safe-ds to ^0.24.0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 8, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 6 0 0 0.62s
✅ PYTHON mypy 6 0 1.76s
✅ PYTHON ruff 6 0 0 0.04s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90de957) to head (d410992).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##              main      #164    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7        10     +3     
  Lines           37       151   +114     
==========================================
+ Hits            37       151   +114

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marsmaennchen221
Copy link
Copy Markdown
Contributor Author

Marsmaennchen221 commented May 8, 2024

@lars-reimann Currently, the tests download each dataset once. Therefore, the tests take a while. Do you have an idea what we could do about that?

@Marsmaennchen221
Copy link
Copy Markdown
Contributor Author

Marsmaennchen221 commented May 8, 2024

@lars-reimann as soon as the next release of the Library is published, we can merge this pr

@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented May 9, 2024 •
edited
Loading

@lars-reimann Currently, the tests download each dataset once. Therefore, the tests take a while. Do you have an idea what we could do about that?

https://github.com/actions/cache could help here, if the data is not too large. We have 10 GB for caches in total.

lars-reimann
lars-reimann reviewed May 9, 2024
View reviewed changes
lars-reimann
lars-reimann reviewed May 9, 2024
View reviewed changes
lars-reimann
lars-reimann reviewed May 9, 2024
View reviewed changes
Marsmaennchen221 and others added 2 commits May 9, 2024 17:30
@Marsmaennchen221
Copy link
Copy Markdown
Contributor Author

Marsmaennchen221 commented May 9, 2024

@lars-reimann Currently, the tests download each dataset once. Therefore, the tests take a while. Do you have an idea what we could do about that?

https://github.com/actions/cache could help here, if the data is not too large. We have 10 GB for caches in total.

Ok I will look at this at a later time. For now, this pr is ready.

@Marsmaennchen221 Marsmaennchen221 marked this pull request as ready for review May 9, 2024 16:08
@Marsmaennchen221 Marsmaennchen221 requested a review from a team as a code owner May 9, 2024 16:08
@Marsmaennchen221 Marsmaennchen221 mentioned this pull request May 9, 2024
Open
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented May 9, 2024

OK, thanks. Review will take a while. I have other priorities right now.

@Marsmaennchen221 Marsmaennchen221 mentioned this pull request May 19, 2024
Merged
@Marsmaennchen221
fix: tensor of mnist datasets now uses correct dtype uint8
7726fa0 
build: mnist supports api changes made in Safe-DS 0.25
@Marsmaennchen221
Merge branch 'main' of https://github.com/Safe-DS/Datasets into add-m…
b523490 
…nist-datasets

# Conflicts:
#	poetry.lock
#	pyproject.toml
@Marsmaennchen221
build: bump safe-ds to >=0.24
d410992
@lars-reimann lars-reimann merged commit 97ae47a into main Jul 12, 2024
@lars-reimann lars-reimann deleted the add-mnist-datasets branch July 12, 2024 07:28
lars-reimann pushed a commit that referenced this pull request Oct 2, 2024
@semantic-release-bot
chore(release): 0.19.0 [skip ci]
26f0bf4 
## [0.19.0](v0.18.0...v0.19.0) (2024-10-02)

### Features

* added MNIST, Fashion-MNIST and KMNIST datasets ([#164](#164)) ([97ae47a](97ae47a)), closes [#161](#161) [#162](#162) [#163](#163)

### Bug Fixes

* **deps:** bump jinja2 from 3.1.3 to 3.1.4 ([#160](#160)) ([e3bcc83](e3bcc83)), closes [/jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-4](https://github.com/Safe-DS//jinja.palletsprojects.com/en/3.1.x/changes//issues/version-3-1-4) [/jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-4](https://github.com/Safe-DS//jinja.palletsprojects.com/en/3.1.x/changes//issues/version-3-1-4) [#1968](https://github.com/Safe-DS/Datasets/issues/1968) [#5457](https://github.com/Safe-DS/Datasets/issues/5457)
* **deps:** bump scikit-learn from 1.4.2 to 1.5.0 ([#178](#178)) ([a3389c9](a3389c9)), closes [#29039](https://github.com/Safe-DS/Datasets/issues/29039) [#29007](https://github.com/Safe-DS/Datasets/issues/29007) [#27108](https://github.com/Safe-DS/Datasets/issues/27108) [#28592](https://github.com/Safe-DS/Datasets/issues/28592) [#28951](https://github.com/Safe-DS/Datasets/issues/28951) [#29029](https://github.com/Safe-DS/Datasets/issues/29029)
* **deps:** bump urllib3 from 2.2.1 to 2.2.2 ([#177](#177)) ([5f20711](5f20711)), closes [#3122](https://github.com/Safe-DS/Datasets/issues/3122) [#3363](https://github.com/Safe-DS/Datasets/issues/3363) [#3122](https://github.com/Safe-DS/Datasets/issues/3122) [#3363](https://github.com/Safe-DS/Datasets/issues/3363) [#3406](https://github.com/Safe-DS/Datasets/issues/3406) [#3398](https://github.com/Safe-DS/Datasets/issues/3398) [#3399](https://github.com/Safe-DS/Datasets/issues/3399) [#3396](https://github.com/Safe-DS/Datasets/issues/3396) [#3394](https://github.com/Safe-DS/Datasets/issues/3394) [#3391](https://github.com/Safe-DS/Datasets/issues/3391) [#3316](https://github.com/Safe-DS/Datasets/issues/3316) [#3387](https://github.com/Safe-DS/Datasets/issues/3387) [#3386](https://github.com/Safe-DS/Datasets/issues/3386)
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Oct 2, 2024

🎉 This PR is included in version 0.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lars-reimann lars-reimann lars-reimann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the KMNIST Dataset Add the Fashion-MNIST Dataset Add the MNIST Dataset

3 participants

@Marsmaennchen221 @lars-reimann @megalinter-bot