Skip to content

[autobackport: sssd-2-9] Tests: Add missing infopipe tests to remaining branched#8377

Merged
jakub-vavra-cz merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8360-to-sssd-2-9
Jan 21, 2026
Merged

[autobackport: sssd-2-9] Tests: Add missing infopipe tests to remaining branched#8377
jakub-vavra-cz merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8360-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Contributor

@sssd-bot sssd-bot commented Jan 19, 2026

This is an automatic backport of PR#8360 Tests: Add missing infopipe tests to remaining branched to branch sssd-2-9, created by @aborah-sudo.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8360-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8360-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8360-to-sssd-2-9 --force

Original commits
4630cb4 - Tests: Add missing infopipe tests to remaining branched

Backported commits

  • d6ac473 - Tests: Add missing infopipe tests to remaining branched

Original Pull Request Body

Add missing infopipe tests to remaining branched

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 19, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automatic backport that adds a comprehensive suite of tests for the SSSD InfoPipe responder. The new test file, src/tests/system/test_infopipe.py, covers various aspects of the InfoPipe functionality, including user and group property lookups, domain property access, listing entities by attributes and name, and handling of extra attributes. The tests are well-structured and cover a wide range of scenarios. I have reviewed the changes and found no high or critical issues. The added tests improve the test coverage for the InfoPipe component, which is a valuable addition.

@aborah-sudo aborah-sudo force-pushed the SSSD-sssd-backport-pr8360-to-sssd-2-9 branch from d6ac473 to 9ca77eb Compare January 19, 2026 08:06
@aborah-sudo
Tests: Add missing infopipe tests to remaining branched
a906f3e 
Add missing infopipe tests to remaining branched

(cherry picked from commit 4630cb4)
@aborah-sudo aborah-sudo force-pushed the SSSD-sssd-backport-pr8360-to-sssd-2-9 branch from 9ca77eb to a906f3e Compare January 19, 2026 08:08
@aborah-sudo aborah-sudo added Waiting for review Tests Trivial A single reviewer is sufficient to review the Pull Request no-backport This should go to target branch only. labels Jan 19, 2026
@sssd-bot
Copy link
Contributor Author

sssd-bot commented Jan 21, 2026

The pull request was accepted by @jakub-vavra-cz with the following PR CI status:

🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🔴 Static code analysis / python-system-tests (failure)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

jakub-vavra-cz
jakub-vavra-cz approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ci failures are unrelated.

@jakub-vavra-cz jakub-vavra-cz merged commit ffe1445 into SSSD:sssd-2-9 Jan 21, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jakub-vavra-cz jakub-vavra-cz

Labels

Accepted no-backport This should go to target branch only. Tests Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sssd-bot @jakub-vavra-cz @aborah-sudo