Skip to content

Tests: Add missing infopipe tests to remaining branched#8360

Merged
jakub-vavra-cz merged 1 commit intoSSSD:sssd-2-9-4from
aborah-sudo:new_2_9
Jan 19, 2026
Merged

Tests: Add missing infopipe tests to remaining branched#8360
jakub-vavra-cz merged 1 commit intoSSSD:sssd-2-9-4from
aborah-sudo:new_2_9

Conversation

@aborah-sudo
Copy link
Contributor

@aborah-sudo aborah-sudo commented Jan 16, 2026

Add missing infopipe tests to remaining branched

@aborah-sudo
Tests: Add missing infopipe tests to remaining branched
48fe462 
Add missing infopipe tests to remaining branched
@aborah-sudo aborah-sudo added Waiting for review Tests Trivial A single reviewer is sufficient to review the Pull Request backport-to-sssd-2-8 backport-to-sssd-2-9 labels Jan 16, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 16, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive suite of system tests for the SSSD InfoPipe (IFP) responder. The tests cover a wide range of IFP D-Bus API functionality, including user and group lookups, property retrieval, and listing. The test cases are well-structured and seem to correctly validate the expected behavior. I have one high-severity suggestion to improve code quality and prevent potential bugs by renaming a variable that shadows a Python built-in.

jakub-vavra-cz
jakub-vavra-cz approved these changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-vavra-cz jakub-vavra-cz merged commit 4630cb4 into SSSD:sssd-2-9-4 Jan 19, 2026
20 of 21 checks passed
@sssd-bot
Copy link
Contributor

sssd-bot commented Jan 19, 2026

The pull request was accepted by @jakub-vavra-cz with the following PR CI status:

🟢 CodeQL (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-8) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

This was referenced Jan 19, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jakub-vavra-cz jakub-vavra-cz

Labels

Accepted backport-to-sssd-2-9 Tests Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aborah-sudo @sssd-bot @jakub-vavra-cz