[autobackport: sssd-2-9] Tests: ADuser external group cache update#8247
Conversation
There was a problem hiding this comment.
Code Review
This pull request backports a test case for an issue where an AD user's external group memberships were not updated correctly after cache expiration, especially when dealing with a large number of groups. The new test test_ipa_trusts__aduser_membership_update_cache is added to src/tests/system/tests/test_ipa_trusts.py.
My review focuses on the correctness and clarity of the new test. I've found a significant discrepancy between the test's documentation (docstring) and its implementation, particularly concerning the number of groups created. This could affect the test's ability to validate the intended fix. I've left a detailed comment with suggestions for improvement.
2f25466 to
e5e803f
Compare
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
thank you for the updates, ACK.
bye,
Sumit
e5e803f to
8ed74d4
Compare
8ed74d4 to
776fbc3
Compare
|
Hi, I'm not sure if it is a good idea to change the content of the test in a backport. I'm afraid we might get lost to understand what is tested in which branch. bye, |
I agree. I've raised 8255 for master as well. Now, the master and the backport should be in sync. |
AD user in external group is not cleared when expiring the cache In IPA-AD trust, a ADuser is member of large number of IPA groups. When ADuser is removed from one external-group, and cache of ADuser is expired, subsequent look up should update the cache correctly. verifies SSSD#7938 Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit ec81ea2)
|
The pull request was accepted by @sumit-bose with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
776fbc3 to
770ed1f
Compare
This is an automatic backport of PR#8046 Tests: ADuser external group cache update to branch sssd-2-9, created by @shridhargadekar.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
ec81ea2 - Tests: ADuser external group cache update
Backported commits
Original Pull Request Body
In IPA-AD trust, a AD user is member of large number of IPA groups. When AD user is removed from one external-group, and cache of AD user is expired, subsequent look up of that AD user should update the user cache correctly.
verifies #7938