Tests: Rectify the docstring n testcode#8255
Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom Dec 5, 2025
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request corrects the docstrings in test_ipa_trusts__aduser_membership_update_cache to match the number of groups used in the test code (10 instead of 4000). It also adds a valuable assertion to verify the initial number of group memberships. My review includes a suggestion to refactor the hardcoded number of groups into a constant to improve the test's maintainability and prevent future inconsistencies.
jakub-vavra-cz
approved these changes
Dec 2, 2025
jakub-vavra-cz
requested changes
Dec 2, 2025
Contributor
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
Looks like the test is failing
216fbfc to
83b0cd4
Compare
Contributor
Author
|
Now the test is passing. One assertion failed as the user will have additional two group-membership of |
Modifying the doc-string to reflect correct group number. Added verification of number of groups the user is part of initially. Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Contributor
jakub-vavra-cz
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying test case doc-string to reflect correct group number.
Added verification of number of groups the user is part of initially.