[autobackport: sssd-2-9] SPEC: require reasonably up to date 'libldb' version#8242
Conversation
67e7da0 to
f2392f9
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the RPM spec file to dynamically determine the required libldb version based on the samba-devel package version present at build time. This is a good improvement as it removes a hardcoded version string. However, I've found a critical issue where the minimum version check for libldb-devel at build time has been removed. Given that there was an ABI break in libldb at version 1.2.0, removing this check could result in building a non-functional package if an older version of libldb-devel is used. I have left a comment with a suggestion to reintroduce this important safety check.
| %endif | ||
| BuildRequires: libini_config-devel >= 1.1 | ||
| BuildRequires: libldb-devel >= %{ldb_version} | ||
| BuildRequires: libldb-devel |
There was a problem hiding this comment.
Removing the version constraint for libldb-devel could lead to building sssd against an older, ABI-incompatible version of the library. The comment on line 193 highlights an ABI break at version 1.2.0. Without this build-time check, it's possible to produce a package that will fail at runtime if the build environment has an older libldb-devel. To prevent this, it's safer to enforce a minimum version for the build dependency. While the goal was to remove hardcoded versions, safety should be prioritized here.
BuildRequires: libldb-devel >= 1.2.0
|
Failing 'FAILED tests/test_access_control_simple.py::test_access_control_simple__permits_user_login_based_on_group' isn't relevant. |
Since 'libldb' is built from Samba sources, it uses the same version. Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked with amendments from commit bbbd150) Reviewed-by: Sumit Bose <sbose@redhat.com>
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
f2392f9 to
31ff199
Compare
This is an automatic backport of PR#8240 SPEC: require reasonably up to date 'libldb' version to branch sssd-2-9, created by @alexey-tikhonov.
Caution
@alexey-tikhonov The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
bbbd150 - SPEC: require reasonably up to date 'libldb' version
Backported commits
Original Pull Request Body
Since 'libldb' is built from Samba sources, it uses the same version.