SPEC: require reasonably up to date 'libldb' version#8240
SPEC: require reasonably up to date 'libldb' version#8240alexey-tikhonov merged 1 commit intoSSSD:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request strengthens the runtime dependency of the sssd-common package on libldb. By adding a version requirement (>= %{samba_package_version}), it ensures that the installed libldb is at least as new as the samba-devel package used during the build. This is a good improvement as it prevents potential ABI compatibility issues at runtime, given that libldb is versioned in lockstep with Samba. The change is consistent with existing versioned dependencies on samba-client-libs in other SSSD subpackages. The implementation is correct and I see no issues.
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
thank you for the patch, makes sense, and backporting to 2-9 (RHEL-9) should be ok as well, ACK.
|
C10S CI is red due to known issue: |
Since 'libldb' is built from Samba sources, it uses the same version. Reviewed-by: Sumit Bose <sbose@redhat.com>
Since 'libldb' is built from Samba sources, it uses the same version.