Support encoding and decoding trust stores#10
Merged
AGWA merged 1 commit intoSSLMate:masterfrom Apr 8, 2020
Merged
Conversation
Contributor
Author
|
@AGWA Could you have a look at this PR? |
AGWA
requested changes
Apr 8, 2020
Member
AGWA
left a comment
There was a problem hiding this comment.
Looks pretty good. I requested a few small changes.
Contributor
Author
|
@AGWA I pushed a commit that addresses your review comments so far. Let me know if/when you want me to squash the commits. |
Member
|
@luluF looks good, thanks! Please do go ahead and squash. |
2e563d6 to
7b650a0
Compare
Contributor
Author
|
@AGWA Done, thank you for taking the time to review. |
Member
AGWA
added a commit
that referenced
this pull request
Jul 14, 2023
Instead of calling pkcs12.Encode, call the Encode method of an Encoder. (Likewise for EncodeTrustStore and EncodeTrustStoreEntries.) The following Encoders are available: * Legacy, for the current behavior. * LegacyDESCerts, to use 3DES for encrypting certificates (Closes #36, Closes #35). * Passwordless, to create password-less trust stores like Java 18 (Closes #10). * Openssl3, to match OpenSSL's modern algorithm choices (Closes #47). * Modern, to always use the most modern choices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.