Remove secrets from public workflow #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
StaehliJ
approved these changes
Feb 18, 2025
MGaetan89
added a commit
that referenced
this pull request
Mar 4, 2025
In #899, the `cache-encryption-key` argument was removed from the `gradle/actions/setup-gradle` action in order to avoid using secrets. However, this secrets is optional: if the value is not provided, the cache won't be read or updated. This means that PRs created from the main repository will take advantage of Gradle's Configuration Cache, while PRs from forks won't.
MGaetan89
added a commit
that referenced
this pull request
Mar 4, 2025
In #899, the `cache-encryption-key` argument was removed from the `gradle/actions/setup-gradle` action to avoid using secrets. However, this secret is optional: if the value is not provided, the cache won't be read or updated. This means that PRs created from the main repository will take advantage of Gradle's Configuration Cache, while PRs from forks won't.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR removes secrets from public workflows (those who run on PR). It also updates Gradle to 8.12.1 and removes the
buildstep from thequality.ymlworkflow.Changes made
secrets.GITHUB_TOKENwithgithub.token. Both are equivalent, but usinggithub.tokenshows that it's not a custom secret.secrets.GRADLE_CACHE_ENCRYPTION_KEYfrom thegradle/actionsaction. It means that we will cache slightly less data, but it probably won't have a big impact on build time.buildstep from thequality.ymlworkflow. This probably had no significant advantage in terms of performance. So now each step is independent.Checklist