Skip to content

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Sep 26, 2024

Pull request

Description

Following the merge of #703, some Detekt rules (in particular about the documentation) are no longer enabled. I went through the old Detekt config file and added the missing rules.

Changes made

  • Re-enable rules for documentation.
  • Re-enable rules for complexity.
  • Re-enable rules for coroutines.
  • Re-enable rules for naming.
  • Re-enable rules for style.
  • Adjust some formatting rules (was not done before).

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 requested a review from StaehliJ September 26, 2024 09:15
@MGaetan89 MGaetan89 self-assigned this Sep 26, 2024
@github-actions
Copy link

Code Coverage

Overall Project 49.87% 🟢
Module Coverage
:pillarbox-core-business 80.38% 🟢
:pillarbox-player 59.77% 🟢
Files
Module File Coverage
:pillarbox-core-business IlHost.kt 100% 🟢
:pillarbox-player EventMessageData.kt 76.95% 🟢

@MGaetan89 MGaetan89 mentioned this pull request Sep 26, 2024
6 tasks
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goood

@StaehliJ StaehliJ added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit e22ae35 Sep 26, 2024
@StaehliJ StaehliJ deleted the update_detekt_config branch September 26, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants