Skip to content

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Sep 14, 2024

Pull request

Description

This PR extracts Detekt's config into a new custom plugin PillarboxDetektPlugin. It also strips the detekt.yml file of all the default values to keep only the custom configuration that we need.
This means that we now have a bunch of new activated rules. Those that impacted the project in this PR are:

  • Either all arguments fit on one line, or each argument is on its own line (see the changes in ILRepository for an example).
  • Braces are always required on expressions if they don't fit on one line (see the changes in FakeAssetLoader for an example).

If you prefer to keep the previous behavior, let me know, and I'll adjust the rule accordingly.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 requested a review from StaehliJ September 14, 2024 15:31
@MGaetan89 MGaetan89 self-assigned this Sep 14, 2024
@MGaetan89 MGaetan89 force-pushed the use_default_detekt_config branch from 9230c08 to 22b13e1 Compare September 14, 2024 15:38
@github-actions
Copy link

Code Coverage

Overall Project 50.09% -1.62% 🟢
Files changed 8.36% 🟢

Module Coverage
:pillarbox-player 60.12% -0.21% 🟢
Kover Gradle Plugin XML report for :plugins 7.72% -18.39% 🟢
:pillarbox-ui 0.06% -3.63% 🟢
Files
Module File Coverage
:pillarbox-player PlayerCallbackFlow.kt 70.44% 🟢
PillarboxAnalyticsCollector.kt 64.19% -22.3% 🟢
TrackSelectionParameters.kt 1.46% 🟢
PillarboxMediaController.kt 0% -0.05% 🟢
Kover Gradle Plugin XML report for :plugins PillarboxDetektPlugin.kt 0% 🟢
ProjectExtensions.kt 0% -9.56% 🟢
AppConfig.kt 0% 🟢
:pillarbox-ui PlayerSurface.kt 0.33% -4.69% 🟢
SphericalSurface.kt 0% -34.39% 🟢
ExoPlayerView.kt 0% -13.73% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit c7a7167 Sep 16, 2024
@MGaetan89 MGaetan89 deleted the use_default_detekt_config branch September 16, 2024 10:48
@MGaetan89 MGaetan89 mentioned this pull request Sep 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants