Skip to content

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Sep 17, 2024

Pull request

Description

Up until now, we were changing the LocalLayoutDirection in PlaybackSettingsDrawer in order to have the drawer displayed on the right side of the screen.
With a recent release of Compose, this introduces a regression where navigating in a submenu of the drawer goes back to the root of the navigation after a second.
Since the initial approach was more a workaround, I've removed it and left the drawer on the left side of the screen.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Sep 17, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Sep 17, 2024

Code Coverage

Overall Project 49.89% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ added this pull request to the merge queue Sep 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2024
@MGaetan89 MGaetan89 force-pushed the 702-fix-player-setting-drawer-in-pillarbox-demo-tv branch from c5639b6 to 644c9db Compare September 18, 2024 11:43
@MGaetan89 MGaetan89 enabled auto-merge September 18, 2024 11:43
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 78986fa Sep 18, 2024
@MGaetan89 MGaetan89 deleted the 702-fix-player-setting-drawer-in-pillarbox-demo-tv branch September 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Fix player setting drawer in pillarbox-demo-tv

2 participants