Skip to content

Store pillarbox data into current tracks #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 17 commits into from
Sep 17, 2024
Merged

Store pillarbox data into current tracks #704

StaehliJ merged 17 commits into from
Sep 17, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Sep 16, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to allow integrators to use MediaItem.tag this tag is no more used internally by Pillarbox. PillarboxData is now stored in the track list of the player when content is loaded.

Changes made

  • PillarboxData can be retrieved with Player.currentTracks.getPillarboxDataOrNull().
  • PillarboxExoPlayer doesn't override MediaItem.tag.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@github-actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Code Coverage

Overall Project 49.78% -0.08% 🟢
Files changed 94.39% 🟢

Module Coverage
:pillarbox-core-business 80.4% 🟢
:pillarbox-player 59.6% -0.15% 🟢
Files
Module File Coverage
:pillarbox-core-business SRGAssetLoader.kt 86.17% 🟢
SRGMediaItemBuilder.kt 81.4% 🟢
:pillarbox-player PillarboxMediaPeriod.kt 100% 🟢
Tracks.kt 99.52% -0.48% 🟢
AnalyticsMediaItemTracker.kt 95.12% -2.44% 🟢
TimeRangeTracker.kt 95.06% 🟢
CurrentMediaItemPillarboxDataTracker.kt 93.9% -4.88% 🟢
PillarboxMediaSource.kt 87.08% -2.08% 🟢
PillarboxExoPlayer.kt 81.09% 🟢
PlaybackService.kt 0% 🟢

MGaetan89
MGaetan89 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small comment.

I've removed the PillarboxMediaPeriod.selectTracks() as we discussed, updated some documentation, and fixed some warnings.

@StaehliJ StaehliJ enabled auto-merge September 17, 2024 08:37
@StaehliJ StaehliJ added this pull request to the merge queue Sep 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Sep 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Sep 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@StaehliJ StaehliJ force-pushed the store-pillarbox-data-into-tracks branch from 968b1d0 to b3695de Compare September 17, 2024 13:31
@StaehliJ StaehliJ enabled auto-merge September 17, 2024 13:36
@StaehliJ StaehliJ added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 231c650 Sep 17, 2024
@StaehliJ StaehliJ deleted the store-pillarbox-data-into-tracks branch September 17, 2024 13:42
MGaetan89 added a commit that referenced this pull request Sep 18, 2024
@StaehliJ @MGaetan89
Store pillarbox data into current tracks (#704)
105420e 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StaehliJ StaehliJ

Labels

None yet

Projects

Pillarbox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StaehliJ @MGaetan89