Update AndroidX Compose #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/DemoPlayerView.kt
Fixed
Show fixed
Hide fixed
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/DemoPlayerView.kt
Fixed
Show fixed
Hide fixed
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/DemoPlayerView.kt
Fixed
Show fixed
Hide fixed
StaehliJ
approved these changes
Sep 11, 2024
Contributor
|
Sounds good for me to use beta version in demo application modules. |
StaehliJ
approved these changes
Sep 11, 2024
MGaetan89
added a commit
that referenced
this pull request
Oct 1, 2024
This PR makes the slider interactive again in `ResizablePlayerShowcase` and `SmoothSeekingShowcase`. The issue was introduced in #698, where `interactionSource` was made optional to follow Android's recommendation. However, these two usages were not updated to provide a non-`null` argument. Fixes #722
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR updates Pillarbox to use Compose 2024.09.00 (1.7.0 and Material3 1.3.0).
Changes made
MutableInteractionSourcewhere possible, as recommended since Compose Foundation 1.7.0.BasicTextFieldoverload that takes aTextFieldState, as recommended since Compose Foundation 1.7.0.Note
It seems that new versions of Compose Material Navigation were not released after 1.7.0-beta01, and went straight to version 1.8.0-alpha01, and it is also missing from the BOM.
I've used 1.7.0-beta01 to be as close to the Compose version as possible. Since it is only used in the demo apps, I think it is fine to use a beta dependency.
Let me know if you prefer to keep Accompanist Navigation Material (which is now deprecated) until a stable version of Compose Material Navigation is released.
Here's a ticket on Google side: https://issuetracker.google.com/issues/347719428
Checklist
mainbranch.