Skip to content

Move TVSlider to pillarbox-demo-shared #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 8 commits into from
Jul 26, 2024
Merged

Move TVSlider to pillarbox-demo-shared #650

StaehliJ merged 8 commits into from
Jul 26, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jul 23, 2024 •
edited
Loading

Pull request

Description

This PR moves TVSlider from pillarbox-demo-tv to pillarbox-demo-shared, under the new PillarboxSlider name.

Changes made

PillarboxSlider

  • Move TVSlider from pillarbox-demo-tv to pillarbox-demo-shared.
  • Rename it PillarboxSlider.
  • Add support for secondary value.
  • Add support for InteractionSource.

Misc

  • Move Modifier.onDpadEvent() from pillarbox-demo-tv to pillarbox-demo-shared.
  • Redesign the ResizablePlayerShowcase.

Screenshots

Description Screenshot 
PillarboxSlider on a player (unfocused) Screenshot_20240723_165716
PillarboxSlider on a player (focused) Screenshot_20240723_165831
New ResizablePlayerShowcase screen Screenshot_20240723_165843

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jul 23, 2024 that may be closed by this pull request
Share the Slider component between mobile and TV #649
Closed
@github-actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Code Coverage

Overall Project 49% 🟢

There is no coverage information present for the Files changed

StaehliJ
StaehliJ reviewed Jul 25, 2024
View reviewed changes
@StaehliJ StaehliJ added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 05c5b07 Jul 26, 2024
@StaehliJ StaehliJ deleted the common_slider_component branch July 26, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Share the Slider component between mobile and TV

2 participants

@MGaetan89 @StaehliJ