13461 chest pain missing from symptoms for plague by KarnaiahPesula · Pull Request #13570 · SORMAS-Foundation/SORMAS-Project

KarnaiahPesula · 2025-08-11T09:04:01Z

Fixes #

Summary by CodeRabbit

Bug Fixes
- Chest pain now only appears for pneumonic plague cases, reducing irrelevant fields and improving data entry accuracy.
New Features
- Chest pain is now grouped under Respiratory symptoms, improving symptom organization and consistency in views, filters, and reports.

…s-for-plague

coderabbitai · 2025-08-11T09:04:08Z

Walkthrough

Adds a respiratory symptom grouping annotation to chestPain in SymptomsDto and updates the UI to show CHEST_PAIN only for cases where PlagueType.PNEUMONIC.

Changes

Cohort / File(s)	Summary of changes
API symptom grouping metadata `sormas-api/.../SymptomsDto.java`	Annotated `chestPain` with `@SymptomGrouping(SymptomGroup.RESPIRATORY)`; no logic changes.
UI visibility rule for chest pain `sormas-ui/.../SymptomsForm.java`	Added import for `PlagueType`; `CHEST_PAIN` visibility now conditional on `caze.getPlagueType() == PlagueType.PNEUMONIC`.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant UI as SymptomsForm
  participant Case as Case Model

  User->>UI: Open symptoms form
  UI->>Case: getPlagueType()
  Case-->>UI: PlagueType (e.g., PNEUMONIC / other)
  UI->>UI: Show CHEST_PAIN only if PlagueType == PNEUMONIC
  UI-->>User: Render form with/without CHEST_PAIN

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I twitch my whiskers at the change,
A chesty tag in tidy range.
If plague breathes pneumonic air,
The form reveals what's hidden there.
A rabbit nods — small hops, precise. 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e17e6e and 2a91664.

📒 Files selected for processing (1)

sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: SORMAS CI
GitHub Check: android app test (28)
GitHub Check: android app test (26)
GitHub Check: android app test (27)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 13461-chest-pain-missing-from-symptoms-for-plague

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

sormas-api/src/main/java/de/symeda/sormas/api/symptoms/SymptomsDto.java (1)

504-506: Chest pain re-grouped to respiratory — verify UX intent

Re-grouping CHEST_PAIN under SymptomGroup.RESPIRATORY affects all diseases globally. If that’s intended (e.g., for pneumonic plague), LGTM; otherwise consider whether CHEST_PAIN should remain under a more general/cardiovascular grouping for non-respiratory diseases.

Confirm with product/UX that CHEST_PAIN should appear in the Respiratory section across all diseases.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acfe63d and 5e17e6e.

📒 Files selected for processing (2)

sormas-api/src/main/java/de/symeda/sormas/api/symptoms/SymptomsDto.java (1 hunks)
sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java (2 hunks)

🔇 Additional comments (1)

sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java (1)

71-71: Import is appropriate

Needed for the new CHEST_PAIN visibility rule.

sormas-vitagroup · 2025-08-11T09:26:47Z

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13570

sormas-vitagroup · 2025-08-11T09:48:43Z

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13570

KarnaiahPesula added 2 commits June 24, 2025 19:46

chest pain is added to the symptoms

f6359f2

Merge branch 'development' into 13461-chest-pain-missing-from-symptom…

5e17e6e

…s-for-plague

KarnaiahPesula linked an issue Aug 11, 2025 that may be closed by this pull request

Chest pain missing from symptoms for Plague #13461

Closed

KarnaiahPesula requested review from obinna-h-n and raulbob August 11, 2025 09:04

coderabbitai bot reviewed Aug 11, 2025

View reviewed changes

Comment thread sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java Outdated

Visibility check for chest pain

2a91664

raulbob approved these changes Aug 13, 2025

View reviewed changes

KarnaiahPesula merged commit 738a87d into development Aug 13, 2025
8 of 13 checks passed

KarnaiahPesula deleted the 13461-chest-pain-missing-from-symptoms-for-plague branch August 13, 2025 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

13461 chest pain missing from symptoms for plague#13570

13461 chest pain missing from symptoms for plague#13570
KarnaiahPesula merged 3 commits intodevelopmentfrom
13461-chest-pain-missing-from-symptoms-for-plague

KarnaiahPesula commented Aug 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

sormas-vitagroup commented Aug 11, 2025

Uh oh!

sormas-vitagroup commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

KarnaiahPesula commented Aug 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sormas-vitagroup commented Aug 11, 2025

Uh oh!

sormas-vitagroup commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KarnaiahPesula commented Aug 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)