Skip to content

Support SHA-256 algorithm (RFC 8760) #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lemenkov merged 1 commit into from
Jan 31, 2024
Merged

Support SHA-256 algorithm (RFC 8760) #676

lemenkov merged 1 commit into from
Jan 31, 2024

Conversation

@Maratk1n
Copy link
Contributor

@Maratk1n Maratk1n commented Dec 17, 2023

No description provided.

@Maratk1n Maratk1n mentioned this pull request Dec 19, 2023
Closed
@orgads
Copy link
Contributor

orgads commented Dec 19, 2023

Thank you!

  1. Please add -DUSE_SHA256=1 also to build.sh in --full.
  2. There are many deprecation warnings with openssl 3. Example:
src/auth.cpp:348:18: warning: ‘int SHA256_Update(SHA256_CTX*, const void*, size_t)’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
  348 |     SHA256_Update( &SHA256Ctx, (unsigned char *) user, strlen(user));
      |     ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@Maratk1n
Copy link
Contributor Author

Maratk1n commented Dec 19, 2023

Hi, @orgads

  1. Done
  2. I replaced openssl/sha with EVP module

Thanks for review!

@orgads
Copy link
Contributor

orgads commented Dec 20, 2023

Thank you!

I didn't test functionality yet, but compilation and tests pass.

orgads
orgads reviewed Dec 22, 2023
View reviewed changes
@orgads
Copy link
Contributor

orgads commented Dec 22, 2023

Verified it works, thank you!

Please remove the flag.

@orgads
Copy link
Contributor

orgads commented Dec 25, 2023

LGTM

@lemenkov
Copy link
Member

lemenkov commented Jan 11, 2024

I've found only a small mostly cosmetic issue. Please address it and rebase on top of current master branch.

@Maratk1n Maratk1n force-pushed the support_sha256_algorithm branch from 3cdbc39 to bcf8221 Compare January 12, 2024 20:49
@Maratk1n
Copy link
Contributor Author

Maratk1n commented Jan 12, 2024 •
edited
Loading

Hi @lemenkov . I've rebased branch and added unit test.

orgads
orgads reviewed Jan 13, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 16, 2024
View reviewed changes
src/auth.cpp
unsigned char *_b = (unsigned char *) _b_raw;

for (i = 0; i < MD5_HASH_SIZE; i++) {
for (i = 0; i < size; i++) {

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition

Comparison between [i](1) of type unsigned short and [size](2) of wider type size_t.
@orgads
Copy link
Contributor

orgads commented Jan 20, 2024

Thank you! Maybe squash all the commits at this point? I would leave only the first one as a separate commit.

@Maratk1n Maratk1n force-pushed the support_sha256_algorithm branch 2 times, most recently from 018d0ec to 538ba8f Compare January 20, 2024 17:42
@Maratk1n
Copy link
Contributor Author

Maratk1n commented Jan 20, 2024

No problem. I've squashed commits and rebased branch.

@orgads
Copy link
Contributor

orgads commented Jan 20, 2024

Thanks! Please resolve the open discussion.

@Maratk1n
Copy link
Contributor Author

Maratk1n commented Jan 20, 2024

Did you mean comment from github-advanced-security bot?
I fixed failure but don't have permission to resolve the thread.

@orgads
Copy link
Contributor

orgads commented Jan 20, 2024

I meant our discussion about CMakeLists. You already resolved it :)

@lemenkov
Copy link
Member

lemenkov commented Jan 28, 2024

Did you mean comment from github-advanced-security bot? I fixed failure but don't have permission to resolve the thread.

@Maratk1n your PR raises a minimum OpenSSL version up to 1.1.0 but still there is a mention of 0.9.8 version in the doc-files. See my notes above.

@Maratk1n Maratk1n force-pushed the support_sha256_algorithm branch from 538ba8f to 1f0b4f9 Compare January 31, 2024 15:40
@Maratk1n
Copy link
Contributor Author

Maratk1n commented Jan 31, 2024

Thank you @lemenkov . Fixed.

@lemenkov
Copy link
Member

lemenkov commented Jan 31, 2024

@orgads looks good to me. What's your opinion?

@orgads
Copy link
Contributor

orgads commented Jan 31, 2024

lgtm

@lemenkov lemenkov merged commit aa0c7da into SIPp:master Jan 31, 2024
lemenkov added a commit to lemenkov/sipp that referenced this pull request Dec 31, 2025
@lemenkov
Remove dead code - we support OpenSSL >= 1.1.0
b07cc74 
Remove dead code - we require OpenSSL >= 1.1.0 since PR SIPp#676.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov added a commit to lemenkov/sipp that referenced this pull request Dec 31, 2025
@lemenkov
Remove dead code - we support OpenSSL >= 1.1.0
cc7b6bb 
Remove dead code - we require OpenSSL >= 1.1.0 since PR SIPp#676.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
@lemenkov lemenkov mentioned this pull request Dec 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orgads orgads orgads left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maratk1n @orgads @lemenkov