Gateway RTP/SRTP bit pattern testing support (SIPP-RTPCHECK-3.6) #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Detailed feature documentation available upon request]
Member
|
Hi! Thanks for the PR. Can you take care of the travis build failures? |
Contributor
Author
|
Hi Walter,
I can probably take care of them -- but it will take a while as I can't promise my availability nowadays... I have a very busy time in the office here. So as long as you don't mind waiting for some time (probably a few weeks at the rate that things are going for me here unfortunately).
As long as there's not too much activity on the SIPp stream it shouldn't be too hard to rebase if I wait a while.
…--
Jeannot Langlois
Software Developer
MiVoice Border Gateway Development
Mitel Networks
350 Legget Drive, Kanata, Ontario K2K 2W7
http://www.mitel.com<http://www.mitel.com/>
“
It’s not over until I win.
“
-- Leslie Brown
From: Walter Doekes <notifications@github.com>
Sent: Wednesday, February 13, 2019 7:55 AM
To: SIPp/sipp <sipp@noreply.github.com>
Cc: Jeannot Langlois <Jeannot.Langlois@mitel.com>; Author <author@noreply.github.com>
Subject: Re: [SIPp/sipp] Gateway RTP/SRTP bit pattern testing support (SIPP-RTPCHECK-3.6) (#381)
Hi!
Thanks for the PR.
Can you take care of the travis build failures?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSIPp%2Fsipp%2Fpull%2F381%23issuecomment-463188883&data=02%7C01%7Cjeannot.langlois%40mitel.com%7Cd843cfb6e5384824e55d08d691b287f8%7C4bff5a2bb30d493981ff8f76138347df%7C1%7C1%7C636856593302727987&sdata=9Q7b%2BdiL9%2Ba1GqksLykP1doAGX91DdOCTZFk9rKYJhU%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAlW1dSI1TkHCMyoDRuNQsbow6JCkEVnhks5vNAtAgaJpZM4a4FyZ&data=02%7C01%7Cjeannot.langlois%40mitel.com%7Cd843cfb6e5384824e55d08d691b287f8%7C4bff5a2bb30d493981ff8f76138347df%7C1%7C1%7C636856593302727987&sdata=k%2BNORZIml7caifEjI7NAG0F8bGLcU0qNKSKN%2FzDyelQ%3D&reserved=0>.
________________________________
NOTE: This e-mail (including any attachments) is for the sole use of the intended recipient(s) and may contain information that is confidential and/or protected by legal privilege. Any unauthorized review, use, copy, disclosure or distribution of this e-mail is strictly prohibited. If you are not the intended recipient, please notify Mitel immediately and destroy all copies of this e-mail. Mitel does not accept any liability for breach of security, error or virus that may result from the transmission of this message.
|
Contributor
|
Hi, I rebased it for you. Checkout https://github.com/orgads/sipp/commits/srtp I also fixed build on Windows, and against openssl 1.1. The changelog entry that you removed looks irrelevant, as 3.6 was already released, so this is for 3.7. You may add a new entry for 3.7. There are many warnings on Windows regarding conversion of pthread_t to int (mostly on printf's). I worked around those who are considered errors (when passing pthread_t to a function that expects int), by casting to long long and then to int, but you should consider really fixing it.. |
Contributor
Author
|
Thanks Shaneh:
I'm away from my workplace for several months as I'm recovering from multiple injuries. Therefore your help is really appreciated.
Unfortunately I might have to wait until later this year to resume my work on SIPP-RTPCHECK. I'm just barely in the slow process of attempting a return to work this month.
I had a good look at the rebased diff, at first glance, things look good.
I do not have my GitHub credentials here at home so I can't leave comments yet. But I will try to do eventually.
Thanks for the help again! :)
…--
Jeannot Langlois
Software Developer
MiVoice Border Gateway Development
Mitel Networks
350 Legget Drive, Kanata, Ontario K2K 2W7
http://www.mitel.com<http://www.mitel.com/>
Jeannot.langlois@mitel.com<mailto:Jeannot.langlois@mitel.com>
(613) 592-5660 x74420
(613) 691-3385 [Direct Dial]
“
It’s not over until I win.
“
-- Leslie Brown
From: Orgad Shaneh <notifications@github.com>
Sent: Tuesday, September 03, 2019 6:01 AM
To: SIPp/sipp <sipp@noreply.github.com>
Cc: Jeannot Langlois <Jeannot.Langlois@mitel.com>; Author <author@noreply.github.com>
Subject: Re: [SIPp/sipp] Gateway RTP/SRTP bit pattern testing support (SIPP-RTPCHECK-3.6) (#381)
Hi,
I rebased it for you. Checkout https://github.com/orgads/sipp/commits/srtp<https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Forgads%2Fsipp%2Fcommits%2Fsrtp&data=02%7C01%7Cjeannot.langlois%40mitel.com%7C239398e7fefd48cff96608d73055a8dc%7C4bff5a2bb30d493981ff8f76138347df%7C1%7C0%7C637031016781466977&sdata=Lh1LcjGL4k5BCCGRYIPtVs7QN37aVkWFG7rNmClFkKY%3D&reserved=0>
I also fixed build on Windows, and against openssl 1.1.
The changelog entry that you removed looks irrelevant, as 3.6 was already released, so this is for 3.7. You may add a new entry for 3.7.
There are many warnings on Windows regarding conversion of pthread_t to int (mostly on printf's). I worked around those who are considered errors (when passing pthread_t to a function that expects int), by casting to long long and then to int, but you should consider really fixing it..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSIPp%2Fsipp%2Fpull%2F381%3Femail_source%3Dnotifications%26email_token%3DAJK3K5OOOULHV4DU2HP4LR3QHYYWXA5CNFSM4GXALSM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XV2UY%23issuecomment-527392083&data=02%7C01%7Cjeannot.langlois%40mitel.com%7C239398e7fefd48cff96608d73055a8dc%7C4bff5a2bb30d493981ff8f76138347df%7C1%7C0%7C637031016781466977&sdata=TAgm2doleHOoJQzIh4WEEcqvYYkuNHrGhXfwo5koJxs%3D&reserved=0>, or mute the thread<https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJK3K5JSM26L2NUFB6FVXFTQHYYWXANCNFSM4GXALSMQ&data=02%7C01%7Cjeannot.langlois%40mitel.com%7C239398e7fefd48cff96608d73055a8dc%7C4bff5a2bb30d493981ff8f76138347df%7C1%7C0%7C637031016781476981&sdata=audgtEkXaBqLCPdJ%2BRrxAT9E%2FDTLpiKJGUHjl7pDJbc%3D&reserved=0>.
________________________________
NOTE: This e-mail (including any attachments) is for the sole use of the intended recipient(s) and may contain information that is confidential and/or protected by legal privilege. Any unauthorized review, use, copy, disclosure or distribution of this e-mail is strictly prohibited. If you are not the intended recipient, please notify Mitel immediately and destroy all copies of this e-mail. Mitel does not accept any liability for breach of security, error or virus that may result from the transmission of this message.
|
Contributor
|
Closing this, as the discussion is continuing on #417. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Detailed feature documentation available upon request]
NOTE: Requires --with-rtpstream --with-openssl