Fix a few memory leaks at shutdown. #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
static char* get_inet_address(struct sockaddr_storage& addr, char* dst, int len)Might be a little nicer. But I'm not particularly concerned.
Contributor
|
Should we turn those "to run with valgrind" instructions into a Makefile target (make vg_run, make vg_test?). |
wdoekes
referenced
this pull request
Jul 12, 2015
To run valgrind:
# make sipp without optimization
make CFLAGS="-g -O0" CXXFLAGS="-g -O0"
# run sipp with valgrind
valgrind --partial-loads-ok=yes --show-leak-kinds=all \
--leak-check=full \
sipp SIPP_ARGUMENTS | cat
# (the extra cat disables curses, which can show distracting leaks)
See also the new regression test in regress/github-#0156.
wdoekes
referenced
this pull request
Jul 12, 2015
To run valgrind:
# make sipp without optimization
make CFLAGS="-g -O0" CXXFLAGS="-g -O0"
# run sipp with valgrind
valgrind --partial-loads-ok=yes --show-leak-kinds=all \
--leak-check=full \
sipp SIPP_ARGUMENTS | cat
# (the extra cat disables curses, which can show distracting leaks)
See also the new regression test in regress/github-#0156.
To run valgrind:
# make sipp without optimization
make CFLAGS="-g -O0" CXXFLAGS="-g -O0"
# run sipp with valgrind
valgrind --partial-loads-ok=yes --show-leak-kinds=all \
--leak-check=full \
sipp SIPP_ARGUMENTS | cat
# (the extra cat disables curses, which can show distracting leaks)
See also the new regression test in regress/github-#0156.
Member
Author
I added a regression test instead. |
wdoekes
added a commit
that referenced
this pull request
Apr 23, 2018
jeannotlanglois
added a commit
to jeannotlanglois/sipp
that referenced
this pull request
May 10, 2018
Will need to find a way to setup the environment on my machine to avoid the need of submitting one pull request everytime to check...
wdoekes
added a commit
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run valgrind: