Skip to content

Fix the retryFailed option does not get modified by optionsProcessor #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dreampiggy merged 1 commit into from
Jul 18, 2025
Merged

Fix the retryFailed option does not get modified by optionsProcessor #3829

dreampiggy merged 1 commit into from
Jul 18, 2025
+1 −1

Conversation

@dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Jul 17, 2025 •
edited by coderabbitai bot
Loading

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

This close #3828

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of image loading failures by ensuring retry options are correctly applied based on processed settings.

@coderabbitai
Copy link

coderabbitai bot commented Jul 17, 2025 •
edited
Loading

Walkthrough

The change updates the logic in the SDWebImageManager so that the SDWebImageRetryFailed flag is now checked from the processed options result, rather than directly from the input options parameter. This ensures the blacklisted URL logic correctly respects options set by an options processor.

Changes

File(s) Change Summary
SDWebImage/Core/SDWebImageManager.m Modified blacklisted URL logic to use SDWebImageRetryFailed from processed options result.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant SDWebImageManager
    participant OptionProcessor

    Caller->>SDWebImageManager: loadImageWithURL(options, context, ...)
    SDWebImageManager->>OptionProcessor: Process options/context
    OptionProcessor-->>SDWebImageManager: Return processed result
    SDWebImageManager->>SDWebImageManager: Check SDWebImageRetryFailed in result
    alt URL is empty or blacklisted and RetryFailed not set
        SDWebImageManager->>Caller: Invoke completion with error
    else
        SDWebImageManager->>...: Continue with image loading
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Blacklisted URL logic should account for processed options from option processor (#3828) ✅

Poem

A rabbit hopped through image code,
Where options and flags subtly flowed.
Now blacklists heed the processor's say,
No more failed URLs astray!
With every hop, the logic’s neat—
Bugs retreat on fluffy feet. 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad0f3bb and da69f8e.

📒 Files selected for processing (1)
  • SDWebImage/Core/SDWebImageManager.m (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • SDWebImage/Core/SDWebImageManager.m

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dreampiggy dreampiggy force-pushed the bugfix/retry_failed_processor branch from ad0f3bb to da69f8e Compare July 18, 2025 05:17
@dreampiggy dreampiggy merged commit 82746aa into SDWebImage:master Jul 18, 2025
7 of 8 checks passed
@dreampiggy dreampiggy deleted the bugfix/retry_failed_processor branch July 18, 2025 08:34
@dreampiggy dreampiggy added this to the 5.21.2 milestone Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.21.2

Development

Successfully merging this pull request may close these issues.

Blacklisted url logic doesnt account processed options from option processor

1 participant

@dreampiggy