Skip to content

UIActivityIndicatorView support#131

Closed
leonardoobaptistaa wants to merge 1 commit intomasterfrom
unknown repository
Closed

UIActivityIndicatorView support#131
leonardoobaptistaa wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@leonardoobaptistaa
Copy link
Copy Markdown

just added suport to UIActivityIndicatorView while image is downloading, if you like to add to the main project, here it is.

@rs rs closed this Nov 4, 2012
@nickdaugherty
Copy link
Copy Markdown

Bummer this isn't part of SDWebImage :( Would be very nice to have UIActivityIndicatorViews while images are loading out of the box, rather than adding another external repo or hacking something together.

@ghost
Copy link
Copy Markdown

ghost commented May 8, 2013

+1

3 similar comments
@anton-matosov
Copy link
Copy Markdown

+1

@vittoriom
Copy link
Copy Markdown

+1

@MartinHerman
Copy link
Copy Markdown

+1

@leonardoobaptistaa
Copy link
Copy Markdown
Author

Hey @MartinHerman ,
you can add this other project to your Podfile: https://github.com/JJSaccolo/UIActivityIndicator-for-SDWebImage

They don't want an activity indicator on the main project.

@bpoplauschi
Copy link
Copy Markdown
Member

Hi guys. Sorry it took so much, but I will reopen the pull request and think about this in the near future. Note: I briefly looked at the implementation from JJSaccolo and I would avoid having another set of setImageWithUrl methods just for the usingActivityIndicatorStyle param. That would make this library even harder to maintain. But maybe we can find some other way

@bpoplauschi bpoplauschi reopened this Sep 12, 2014
@bpoplauschi bpoplauschi added this to the 4.0.0 milestone Nov 5, 2014
@Nihility-Ming
Copy link
Copy Markdown

Create a category is nice idea. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants