Skip to content

PATH does not include /sw/bin on OS X#2

Merged
bdbaddog merged 1 commit into
SCons:masterfrom
bdbaddog:fix_print_tuples_in_tests
Sep 25, 2017
Merged

PATH does not include /sw/bin on OS X#2
bdbaddog merged 1 commit into
SCons:masterfrom
bdbaddog:fix_print_tuples_in_tests

Conversation

@bdbaddog

@bdbaddog bdbaddog commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

This issue was originally created at: 2005-05-07 12:52:36.
This issue was reported by: gregnoel.
gregnoel said at 2005-05-07 12:52:36

On OS X, many packages are not provided by Apple, but can be acquired from the
Fink project, which places all of its binaries in /sw/bin. I would imagine that
most Mac developers use fink, so that directory should be added to the PATH when
running on OS X.

This one-line patch does that:

--- Platform/darwin.old Fri May 6 19:50:29 2005
+++ Platform/darwin.py Fri May 6 19:37:52 2005
@@ -38,3 +38,4 @@
def generate(env):
posix.generate(env)
env['SHLIBSUFFIX'] = '.dylib'

  • env['ENV']['PATH'] = env['ENV']['PATH'] + ':/sw/bin'

It's probably not the ideal solution, but it works for me.

stevenknight said at 2005-10-07 19:49:06

Patch has been accepted and integrated for next release. Thanks!

stevenknight said at 2006-01-05 18:14:55

Changing version to "unspecified" to conform to new scheme.

kmaples said at 2006-05-20 17:03:30

making the default milestone consistent across the project

kmaples said at 2006-05-20 17:14:13

making the version consistent across the project

…t print_function under python 2.7 because the print('a','b') effectively becomes printing a tuple which doesn't match the expected strings
@bdbaddog bdbaddog merged commit e43bbea into SCons:master Sep 25, 2017
@bdbaddog bdbaddog changed the title Fix tests which break when using print() and no from __future__ impor… PATH does not include /sw/bin on OS X Jan 2, 2018
@bdbaddog bdbaddog added the P3 label Jan 2, 2018
dmoody256 referenced this pull request in dmoody256/scons Apr 12, 2018
bdbaddog pushed a commit that referenced this pull request Dec 9, 2019
bdbaddog pushed a commit that referenced this pull request Dec 15, 2019
bdbaddog pushed a commit that referenced this pull request Oct 13, 2020
The way runtest.py passes the list of fixture directories is racy because it
sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting
on Python to start the subprocess before that list is overwritten when spawning
the next directory. At least on Windows, the environment is not copied in
subprocess.run so runtest.py may overwrite the list of fixture directories
with the list for test #2 while the subprocess module is still kicking off
test #1. I was able to easily reproduce this by running the command:
`python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py`
a few times in a row. However, with this fix, that command repeatedly succeeds.

To validate ths fix, I also ran that command with "--xml a.xml" and
"--xml a.xml --nopipefiles" to validate that those other executors worked
correctly.
bdbaddog pushed a commit that referenced this pull request Apr 12, 2021
Fix failing tests, restore last ditch default setting in TempFileMunge for TEMPFILEARGESCFUNC
@jediry jediry mentioned this pull request Oct 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant