Skip to content

[BREAKING] Removal of manifestBundler and generateManifestBundle#838

Merged
flovogt merged 3 commits intomainfrom
remove-manifest-bundler
Nov 11, 2022
Merged

[BREAKING] Removal of manifestBundler and generateManifestBundle#838
flovogt merged 3 commits intomainfrom
remove-manifest-bundler

Conversation

@flovogt
Copy link
Member

@flovogt flovogt commented Nov 9, 2022

JIRA: CPOUI5FOUNDATION-529

@flovogt flovogt changed the title [BREAKING] Removement of manifestBundler and generateManifestBundle [BREAKING] Removal of manifestBundler and generateManifestBundle Nov 9, 2022
@coveralls
Copy link

coveralls commented Nov 9, 2022

Coverage Status

Coverage decreased (-0.01%) to 94.706% when pulling 8400544 on remove-manifest-bundler into 2d63f35 on main.

@flovogt flovogt requested review from RandomByte and matz3 November 10, 2022 08:28
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task also should be removed from taskRepository and handled like the other removed tasks (e.g. "createDebugFiles")

@flovogt
Copy link
Member Author

flovogt commented Nov 11, 2022

The task also should be removed from taskRepository and handled like the other removed tasks (e.g. "createDebugFiles")

Done

@flovogt flovogt requested a review from matz3 November 11, 2022 07:35
matz3
matz3 previously approved these changes Nov 11, 2022
@matz3 matz3 dismissed their stale review November 11, 2022 07:49

let me rethink..

@flovogt flovogt merged commit 07a5be2 into main Nov 11, 2022
@flovogt flovogt deleted the remove-manifest-bundler branch November 11, 2022 09:00
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 25, 2025
…ndle (SAP/ui5-builder#838)

BREAKING CHANGE:
The manifestBundler processor and generateManifestBundle task has been removed because it is no longer required for the HTML5 repository in Cloud Foundry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants