[BREAKING] moduleBundler: Always default to optimize: true#685
Merged
Conversation
3174d3c to
da1b137
Compare
optimize: true
RandomByte
previously approved these changes
Jan 18, 2022
bundleOptions are often omitted. So document them as optional and always default 'optimize' to true, even if bundleOptions are specified.
da1b137 to
e3a487f
Compare
RandomByte
previously approved these changes
Jan 18, 2022
RandomByte
approved these changes
Jan 20, 2022
17 tasks
This was referenced Mar 30, 2022
Closed
This was referenced May 4, 2022
Closed
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
…SAP/ui5-builder#685) bundleOptions are often omitted. So document them as optional and always default 'optimize' to true, even if bundleOptions are specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundleOptions are often omitted. So document them as optional and always
default 'optimize' to true, even if bundleOptions are specified.
This also fixes a bug that appeared if no 'bundleOptions' are defined in the ui5.yaml (e.g. sap.ui.webc.common).