[FIX] SmartTemplateAnalyzer: Do not throw in case missing dependency is expected#479
Merged
RandomByte merged 4 commits intomasterfrom Jul 21, 2020
Merged
Conversation
…is expected In some cases it can be expected that SmartTemplateAnalyzer does not have access to second-degree dependencies. In such cases, no error should be thrown. Currently this causes misleading error logs, for example in case of component preload generation for a Fiori Elements project where no framework dependencies are available. Resolves https://github.com/SAP/ui5-builder/issues/404
835bc00 to
b82187f
Compare
matz3
reviewed
Jul 20, 2020
matz3
reviewed
Jul 20, 2020
matz3
previously approved these changes
Jul 21, 2020
matz3
approved these changes
Jul 21, 2020
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
In addition to #479 the generateLibraryPreload should also ignore missing modules when creating a bundle. As only files from the workspace are bundled, it's not a problem when dependencies can't be found. Just for self-contained bundles, this is a problem. See: SAP/ui5-builder#479
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
…pendency is expected (SAP/ui5-builder#479) In some cases it can be expected that SmartTemplateAnalyzer does not have access to second-degree dependencies. In such cases, no error should be thrown. Currently this causes misleading error logs, for example in case of component preload generation for a Fiori Elements project where no framework dependencies are available. Resolves https://github.com/SAP/ui5-builder/issues/404
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
…5-builder#481) In addition to SAP/ui5-builder#479 the generateLibraryPreload should also ignore missing modules when creating a bundle. As only files from the workspace are bundled, it's not a problem when dependencies can't be found. Just for self-contained bundles, this is a problem. See: SAP/ui5-builder#479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases it can be expected that SmartTemplateAnalyzer does not
have access to second-degree dependencies. In such cases, no error
should be thrown. Currently this causes misleading error logs, for
example in case of component preload generation for a Fiori Elements
project where no framework dependencies are available.
Resolves https://github.com/SAP/ui5-builder/issues/404