Skip to content

[FEATURE] clean build folder: Allows developers to clean build folder…#306

Merged
RandomByte merged 1 commit intoSAP:masterfrom
mauriciolauffer:clean-build-folder
Aug 6, 2019
Merged

[FEATURE] clean build folder: Allows developers to clean build folder…#306
RandomByte merged 1 commit intoSAP:masterfrom
mauriciolauffer:clean-build-folder

Conversation

@mauriciolauffer
Copy link
Copy Markdown
Contributor

[FEATURE] clean build folder: Allows developers to clean build folder before start building a project

This PR address the following issue: #45
This PR replaces PR #216 (it had a merge)

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@mauriciolauffer mauriciolauffer mentioned this pull request Aug 2, 2019
3 tasks
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 86.294% when pulling 3b2f7b5 on mauriciolauffer:clean-build-folder into eea10ba on SAP:master.

@RandomByte RandomByte requested review from RandomByte and devtomtom and removed request for devtomtom August 5, 2019 08:23
@RandomByte
Copy link
Copy Markdown
Member

Thanks!

lgtm, @tommyvinhlam for final review

Copy link
Copy Markdown
Member

@devtomtom devtomtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RandomByte RandomByte merged commit 04eb695 into SAP:master Aug 6, 2019
@RandomByte
Copy link
Copy Markdown
Member

I think the next step is to add a CLI parameter.

Since there is already a dest parameter, let's maybe call the new one clean-dest?

@RandomByte
Copy link
Copy Markdown
Member

fyi, we would like to wait with the next UI5 Builder release for the following PR to get merged: #304

Until then, you need to npm link the UI5 CLI repository locally with the UI5 Builder repository in order to test this feature.

@RandomByte
Copy link
Copy Markdown
Member

Update: This feature got released as UI5 Builder v1.4.1.

RandomByte added a commit to SAP/ui5-cli that referenced this pull request Sep 5, 2019
This exposes the UI5 Builders cleanDest parameter that was added
with SAP/ui5-builder#306.

Usage: ui5 build --clean-dest
Description: If present, clean the destination directory before building
Default: false
RandomByte added a commit to SAP/ui5-cli that referenced this pull request Sep 5, 2019
This exposes the UI5 Builders cleanDest parameter that was added
with SAP/ui5-builder#306.

Usage: ui5 build --clean-dest
Description: If present, clean the destination directory before building
Default: false

Resolves https://github.com/SAP/ui5-builder/issues/45
Resolves UI5/cli#182
RandomByte added a commit to SAP/ui5-cli that referenced this pull request Sep 5, 2019
This exposes the UI5 Builders cleanDest parameter that was added
with SAP/ui5-builder#306.

Usage: ui5 build --clean-dest
Description: If present, clean the destination directory before building
Default: false

Resolves https://github.com/SAP/ui5-builder/issues/45
Resolves UI5/cli#182
RandomByte added a commit to SAP/ui5-cli that referenced this pull request Sep 5, 2019
This exposes the UI5 Builders cleanDest parameter that was added
with SAP/ui5-builder#306.

Usage: ui5 build --clean-dest
Description: If present, clean the destination directory before building
Default: false

Resolves https://github.com/SAP/ui5-builder/issues/45
Resolves UI5/cli#182
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 24, 2025
This exposes the UI5 Builders cleanDest parameter that was added
with SAP/ui5-builder#306.

Usage: ui5 build --clean-dest
Description: If present, clean the destination directory before building
Default: false

Resolves https://github.com/SAP/ui5-builder/issues/45
Resolves #182
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 25, 2025
This exposes the UI5 Builders cleanDest parameter that was added
with SAP/ui5-builder#306.

Usage: ui5 build --clean-dest
Description: If present, clean the destination directory before building
Default: false

Resolves https://github.com/SAP/ui5-builder/issues/45
Resolves #182
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 26, 2025
This exposes the UI5 Builders cleanDest parameter that was added
with SAP/ui5-builder#306.

Usage: ui5 build --clean-dest
Description: If present, clean the destination directory before building
Default: false

Resolves https://github.com/SAP/ui5-builder/issues/45
Resolves #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants