Skip to content

[FIX] JSDoc: avoid errors when symbol has no events#1162

Merged
RandomByte merged 1 commit intov4from
fix/jsdoc/AvoidErrorForSymbolWithNoEvents
Oct 7, 2025
Merged

[FIX] JSDoc: avoid errors when symbol has no events#1162
RandomByte merged 1 commit intov4from
fix/jsdoc/AvoidErrorForSymbolWithNoEvents

Conversation

@petermuessig
Copy link
Contributor

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@petermuessig
Copy link
Contributor Author

By using the module: syntax for the seamless wrappers we run now into a build issue with JSDoc as the events are only available at the metadata object but not at the symbol object. With this little fix, the build succeeds again and the jsdoc of the wrappers is generated.

@petermuessig petermuessig force-pushed the fix/jsdoc/AvoidErrorForSymbolWithNoEvents branch from 79331f9 to 9480873 Compare October 7, 2025 12:39
@petermuessig
Copy link
Contributor Author

Sorry, updated to use v4 branch as foundation for the change!

@coveralls
Copy link

Coverage Status

coverage: 94.968%. remained the same
when pulling 9480873 on fix/jsdoc/AvoidErrorForSymbolWithNoEvents
into 6944848 on v4.

@RandomByte RandomByte merged commit 76a072c into v4 Oct 7, 2025
21 checks passed
@RandomByte RandomByte deleted the fix/jsdoc/AvoidErrorForSymbolWithNoEvents branch October 7, 2025 13:32
maxreichmann added a commit to UI5/cli that referenced this pull request Mar 20, 2026
This is a fix for a bug which initially has been fixed in v4 (SAP/ui5-builder#1162) but not upported to v5 yet. This fix also resolves the error occurence found when running `ui5 build jsdoc` in the UI5/sample-app.
This will add a unit test for transformApiJson.js covering this scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants