WIP: Fixing failing jstests#151
Merged
Merged
Conversation
tmbrbr
requested changes
Jul 24, 2023
tmbrbr
approved these changes
Jul 31, 2023
Closed
leeN
added a commit
to leeN/project-foxhound
that referenced
this pull request
Jan 30, 2024
These tests used to be broken in Foxhound and were fixed in SAP#151. This fix was intended to mask the fact that these tests were picking up and failing due to foxhound induced side effects on untainted strings. As we call toString() on objects during TaintOperation creation, the usage of Foxhound can have visible side effects. This is shown here as these tests count how often toString() is called on an object. Now, in this branch we do not create any TaintOperation objects for these specific cases of untainted strings anymore. Consequently, the tests are now passing in their original form.
tmbrbr
pushed a commit
that referenced
this pull request
Jan 31, 2024
These tests used to be broken in Foxhound and were fixed in #151. This fix was intended to mask the fact that these tests were picking up and failing due to foxhound induced side effects on untainted strings. As we call toString() on objects during TaintOperation creation, the usage of Foxhound can have visible side effects. This is shown here as these tests count how often toString() is called on an object. Now, in this branch we do not create any TaintOperation objects for these specific cases of untainted strings anymore. Consequently, the tests are now passing in their original form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
./mach jstestsshows some failing tests, i.e., where foxhound behavior diverges from vanilla Firefox.This PR tracks the progress of fixing these issues. The underlying reason for test failures is that when assembling the taint flow we call String functions internally, which might have observable side effects iff the user overrides those functions.