sqlite3: handle int type in Connection.timeout parameter by ever0de · Pull Request #7237 · RustPython/RustPython

ever0de · 2026-02-27T07:23:20Z

Summary by CodeRabbit

Improvements
- SQLite connection timeout now accepts both floating‑point and integer values, making it easier to supply timeouts in seconds or as whole numbers. The change is backward compatible: existing defaults and behavior are preserved while allowing mixed input types for more flexible configuration.

coderabbitai · 2026-02-27T07:23:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d540e3f and 4385cc7.

⛔ Files ignored due to path filters (2)

Lib/test/test_sqlite3/test_dbapi.py is excluded by !Lib/**
Lib/test/test_sqlite3/test_transactions.py is excluded by !Lib/**

📒 Files selected for processing (1)

crates/stdlib/src/_sqlite3.rs

📝 Walkthrough

Walkthrough

The SQLite connection timeout argument now accepts either a float or an integer via Either<f64, i64]. Initialization pattern-matches the variant, using the float directly or converting the integer to milliseconds, preserving previous behavior while allowing mixed input types.

Changes

Cohort / File(s)	Summary
SQLite3 Timeout Type Extension `crates/stdlib/src/_sqlite3.rs`	Changed `ConnectArgs.timeout` from `f64` to `Either<f64, i64>`. Added `Either` to imports and updated `initialize_db` to pattern-match `Either::A(f)` or `Either::B(i)`, converting integer timeouts to milliseconds and producing a `c_int` timeout value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibbled code beneath the moonlight,
Timeout types now dance just right.
Float or int, both find their way,
Soft hops of logic save the day. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding support for integer type in the Connection.timeout parameter, which aligns with the switch from f64 to Either<f64, i64> type.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-02-27T07:23:57Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/sqlite3
[ ] test: cpython/Lib/test/test_sqlite3 (TODO: 80)

dependencies:

sqlite3

dependent tests: (2 tests)

sqlite3: test_dbm_sqlite3 test_sqlite3

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

youknowone · 2026-02-27T11:56:34Z

crates/stdlib/src/_sqlite3.rs

-        #[pyarg(any, default = 5.0)]
-        timeout: f64,
+        #[pyarg(any, default = Either::A(5.0))]
+        timeout: Either<f64, i64>,


Parsing timeout as Either<f64, i64> is a common pattern in Python. If you are interested in, investigating if introducing TimeoutSeconds utility type will be useful or not. (I am not sure yet)

I also think it's a great idea. Do you think it would be better to separate it into a new PR instead of working on it here?

sure, in separate PR. it is unrelated refactoring

Follow-up refactoring from RustPython#7237. Python timeout parameters typically accept both float and int. Several places in the codebase used Either<f64, i64> for this, each repeating the same match-and-convert boilerplate. This extracts that into a TimeoutSeconds type in vm::function::number. Refactored sites: - _sqlite3::ConnectArgs.timeout - _thread::AcquireArgs.timeout - _thread::ThreadHandle::join timeout Either<f64, i64> in time.rs (6 sites) left unchanged: those are timestamp values with per-branch logic (floor, range checks, etc). Either<f64, isize> in select.rs also left unchanged (different type).

* Introduce TimeoutSeconds utility type for timeout parameters Follow-up refactoring from #7237. Python timeout parameters typically accept both float and int. Several places in the codebase used Either<f64, i64> for this, each repeating the same match-and-convert boilerplate. This extracts that into a TimeoutSeconds type in vm::function::number. Refactored sites: - _sqlite3::ConnectArgs.timeout - _thread::AcquireArgs.timeout - _thread::ThreadHandle::join timeout Either<f64, i64> in time.rs (6 sites) left unchanged: those are timestamp values with per-branch logic (floor, range checks, etc). Either<f64, isize> in select.rs also left unchanged (different type). * Validate timeout in ThreadHandle::join to prevent panic * refactor: move TimeoutSeconds from number to time module

…7237)

…hon#7271) * Introduce TimeoutSeconds utility type for timeout parameters Follow-up refactoring from RustPython#7237. Python timeout parameters typically accept both float and int. Several places in the codebase used Either<f64, i64> for this, each repeating the same match-and-convert boilerplate. This extracts that into a TimeoutSeconds type in vm::function::number. Refactored sites: - _sqlite3::ConnectArgs.timeout - _thread::AcquireArgs.timeout - _thread::ThreadHandle::join timeout Either<f64, i64> in time.rs (6 sites) left unchanged: those are timestamp values with per-branch logic (floor, range checks, etc). Either<f64, isize> in select.rs also left unchanged (different type). * Validate timeout in ThreadHandle::join to prevent panic * refactor: move TimeoutSeconds from number to time module

ever0de marked this pull request as ready for review February 27, 2026 07:23

youknowone approved these changes Feb 27, 2026

View reviewed changes

sqlite3: handle int type in Connection.timeout parameter

4385cc7

youknowone force-pushed the fix/support-sqlite3-timeout-type-handling branch from d540e3f to 4385cc7 Compare February 27, 2026 11:58

youknowone merged commit 81acb9b into RustPython:main Feb 28, 2026
23 of 25 checks passed

ever0de mentioned this pull request Feb 28, 2026

sqlite3: timeout parameter doesn't accept int ever0de/RustPython#5

Closed

ever0de mentioned this pull request Feb 28, 2026

Introduce TimeoutSeconds utility type for timeout parameters #7271

Merged

youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026

sqlite3: handle int type in Connection.timeout parameter (RustPython#…

022e21f

…7237)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sqlite3: handle int type in Connection.timeout parameter#7237

sqlite3: handle int type in Connection.timeout parameter#7237
youknowone merged 1 commit intoRustPython:mainfrom
ever0de:fix/support-sqlite3-timeout-type-handling

ever0de commented Feb 27, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 27, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

youknowone Feb 27, 2026

Uh oh!

ever0de Feb 27, 2026

Uh oh!

youknowone Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ever0de commented Feb 27, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Library Dependencies

Uh oh!

youknowone Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

ever0de Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

youknowone Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ever0de commented Feb 27, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 27, 2026 •

edited

Loading

github-actions bot commented Feb 27, 2026 •

edited

Loading