Skip to content

zeroize: fixup rust 1.92 warnings#1270

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
baloo:push-pvwuswvwvzzm
Dec 24, 2025
Merged

zeroize: fixup rust 1.92 warnings#1270
tarcieri merged 1 commit intoRustCrypto:masterfrom
baloo:push-pvwuswvwvzzm

Conversation

@baloo
Copy link
Copy Markdown
Member

@baloo baloo commented Dec 23, 2025

#[derive(ZeroizeOnDrop)] was throwing warnings like:

warning: value assigned to `curve` is never read
  --> src/crypto/ecdsa.rs:43:9
   |
43 |         curve: ECCCurve,
   |         ^^^^^
   |
   = help: maybe it is overwritten before being read?
   = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by de

This changes the tests to highlight the new warnings.

@baloo
zeroize: fixup rust 1.92 warnings
ef8543f 
This changes the tests to highlight the new warnings
@baloo baloo mentioned this pull request Dec 23, 2025
Closed
@baloo
Copy link
Copy Markdown
Member Author

baloo commented Dec 23, 2025

If possible, a zeroize_derive 1.5.1 release with that PR would be appreciated!

@tarcieri tarcieri merged commit 5ed71ac into RustCrypto:master Dec 24, 2025
24 checks passed
@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Dec 24, 2025

@baloo hmm, 1.5.0 is still unreleased, and includes an MSRV bump

We should probably get new releases of zeroize and zeroize_derive with that bump out, though I expect some pushback.

@baloo
Copy link
Copy Markdown
Member Author

baloo commented Dec 24, 2025

Ha, right! I didn't even check.

Maybe I should backport this to 1.4 then.

@baloo baloo deleted the push-pvwuswvwvzzm branch December 24, 2025 21:29
baloo added a commit to baloo/utils that referenced this pull request Dec 24, 2025
@baloo
zeroize_derive: fixup rust 1.92 warnings
ba99c6d 
This is a backport of:
 - RustCrypto#1072
 - RustCrypto#1270
@baloo
Copy link
Copy Markdown
Member Author

baloo commented Dec 24, 2025 •
edited
Loading

I don't really have a way to open a PR for a backport because there is no branch to target to.

I've made a commit:

If you could push a 1.4.3, that would be appreciated!

I've checked that commit on rpgp (and 1.92), and it doesn't report any warnings anymore.

@dignifiedquire
Copy link
Copy Markdown
Member

dignifiedquire commented Dec 29, 2025

@tarcieri do you plan on doing a 1.4.x release? I would like to avoid having to allow unused assignments in the whole crate

@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Dec 29, 2025

Yeah, I'll take a look tomorrow

@baloo
Copy link
Copy Markdown
Member Author

baloo commented Dec 29, 2025

a small release of zeroize itself (That bumps the dependency of zeroize_derive) would probably be nice to avoid issues with the minimal-versions checks as well.

@tarcieri tarcieri mentioned this pull request Dec 29, 2025
Closed
@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Dec 29, 2025

This should now be released as v1.4.3: #1310

@baloo re: pinning, I was planning on just cutting zeroize v1.9 and zeroize_derive v1.5 sometime early in January if that works

@baloo
Copy link
Copy Markdown
Member Author

baloo commented Dec 29, 2025

Well, zeroize 1.9 would imply an MSRV bump. Which isn’t something necessarily doable for someone using zeroize 1.8.

this I why I was hinting at a zeroize 1.8.3 with a dependency on zeroize_derive 1.4.3.

otherwise this forces consumers to have a direct dependency on zeroize_derive to force 1.4.3 (to fix the minimal-versions checks). This is at least the case in rpgp, but there might be other consumers.

hko-s added a commit to rpgp/rpgp that referenced this pull request Dec 30, 2025
@hko-s
chore: update zeroize_derive to 1.4.3
3e866f5 
This fixes unhelpful warnings RustCrypto/utils#1270
@hko-s hko-s mentioned this pull request Dec 30, 2025
Merged
hko-s added a commit to rpgp/rpgp that referenced this pull request Dec 30, 2025
@hko-s
chore: update zeroize_derive to 1.4.3
d155807 
This fixes unhelpful warnings RustCrypto/utils#1270
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite
bb77e05 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
@baloo baloo mentioned this pull request Dec 31, 2025
Merged
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
c31a8b1 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
@baloo baloo mentioned this pull request Dec 31, 2025
Closed
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
13472ae 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
6f3a9b9 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
2e4b917 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
2fc3353 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
b7d334e 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
ecdc696 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
833ec84 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
baloo added a commit to baloo/utils that referenced this pull request Dec 31, 2025
@baloo
zeroize_derive: fixup test suite [1.4]
20013dd 
RustCrypto#1270 broke the tests for
zeroize_derive, this fixes the expected output of the tests accordingly.
tarcieri pushed a commit that referenced this pull request Jan 3, 2026
@baloo
zeroize_derive: fixup test suite (#1320)
e02838d 
#1270 broke the tests for `zeroize_derive`, this fixes the expected output of
the tests accordingly.

See $1317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baloo @tarcieri @dignifiedquire