Skip to content

Change Icons and UI Styles#14

Merged
Kokonutic merged 1 commit intomainfrom
topic/icons
Dec 14, 2024
Merged

Change Icons and UI Styles#14
Kokonutic merged 1 commit intomainfrom
topic/icons

Conversation

@Rongbin99
Copy link
Copy Markdown
Owner

@Rongbin99 Rongbin99 commented Dec 14, 2024 •
edited
Loading

This PR removes the old ugly socials and skills icons and replaces them with an icon pack from react-social-icons https://www.npmjs.com/package/react-social-icons. This makes the icons more consistent and more appealing.

  • Add react-social-icons
  • Remove old socials and skills icons
  • Change background color to a gradient
  • Update footer margins
  • Update home page with new jellyfish image

PR CHECKLIST

  • My code follows the style guidelines of this project (variable naming, commenting, copyright, etc.)
  • I have performed a self-review of my code
  • Changes are clearly highlighted and easy to understand
  • I have commented my code, particularly in hard-to-understand areas
  • I have meaningful commit messages that explain what was changed/committed
  • I have built and locally tested my changes
  • My changes generate no new errors or regressions (pending verification)
  • I have made corresponding changes to the documentation OR this is N/A
  • Documentation accurately reflects the current state of the project OR this is N/A
  • I have added tests that prove my fix is effective or that my feature works OR this is N/A
  • New and existing unit tests pass locally with my changes OR this is N/A
  • Any dependent changes have been merged and published in downstream modules OR this is N/A
  • All links are working and correct OR this is N/A
  • Spelling and grammar are correct
  • I have added the "READY FOR REVIEWS" tag when this PR is ready for reviews

@Rongbin99
Icons Overhaul
1b36262 
- Add react-social-icons
- Remove old socials and skills icons
- Change background color to a gradient
- Update footer margins
- Update home page with new jellyfish image
@Rongbin99 Rongbin99 requested a review from Kokonutic as a code owner December 14, 2024 09:10
@Rongbin99 Rongbin99 self-assigned this Dec 14, 2024
@Kokonutic
Copy link
Copy Markdown
Collaborator

Kokonutic commented Dec 14, 2024

PR build and deploy successful https://github.com/Rongbin99/Rongbin99.github.io/actions/runs/12328623300/job/34412086432 new background gradient and social icons are displaying properly in both day and night modes. Performed sanity test and no regressions observed.

Verdict: PASSED

Day Mode
image

Night Mode
image

@Kokonutic Kokonutic merged commit 3c1363b into main Dec 14, 2024
@Kokonutic Kokonutic deleted the topic/icons branch December 14, 2024 09:22
@Kokonutic
Copy link
Copy Markdown
Collaborator

Kokonutic commented Dec 14, 2024

@Rongbin99 PR merged, thank you.

@Rongbin99 Rongbin99 mentioned this pull request Jan 28, 2025
Closed
Rongbin99 added a commit that referenced this pull request Feb 12, 2025
@Rongbin99
Restore Adobe Icons
b1e158f 
Previously removed from #14 accidentially.
@Kokonutic Kokonutic mentioned this pull request Feb 12, 2025
Closed
@Rongbin99 Rongbin99 mentioned this pull request Feb 12, 2025
Merged
15 tasks
Kokonutic pushed a commit that referenced this pull request Feb 12, 2025
@Rongbin99
Fix #18 and #19 and Add PawLog Page (#20)
302b355 
This PR introduces a new Side Project post for PawLog from DeltaHacks XI
back in Jan 2025.

This PR fixes:
- #18 
- #19 
caused by #14 

Commits:
- npm audit fix
- Update Show Ratings
- Restore Adobe Icons #19 
- Fix Issue #18 
- Add PawLog page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kokonutic Kokonutic Kokonutic approved these changes

Assignees

@Rongbin99 Rongbin99

Labels

READY FOR REVIEWS READY TO MERGE TESTING PASSED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rongbin99 @Kokonutic