fix(message-parser): Backtick char in domainChar#861
Merged
Conversation
guijun13
approved these changes
Oct 4, 2022
gabriellsh
added a commit
that referenced
this pull request
Oct 5, 2022
* Add first test * fix: check if is emoticon to preserver colon character * fix(message-parser): Thumbs emoji becoming phone number (#858) Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat> * fix(message-parser): Link/URL parser issues (#855) * feat(fuselage): Adds wordbreak in Box Component (#853) * Fixing URL/links parsing issues * restoring files from base branch * replacing backstick with single quotes Co-authored-by: Douglas Fabris <devfabris@gmail.com> * fixing domainChar accepted chars (#861) * temporarily removing emphasis support Co-authored-by: Filipe Marins <filipemarins123@gmail.com> Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com> Co-authored-by: Douglas Fabris <devfabris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TC-104
Proposed changes (including videos or screenshots)
Problem:
Some combinations of inline code with back-stick was resulting in a plain text, the root cause is because the back-stick was being considered a valid character that should be in the Domain Name of an URL
Solution:
Was added a back-stick char into the invalid chars to parse an URL domain name.
Current behavior
Expected behavior
Issue(s)
Further comments