[FIX] Updated OpenShift Template to take an Image as a Param #9946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set image as a perameter with it defaulting to rocketchat/rocket.chat
The template now uses ROCKETCHAT_IMAGE as a parameter with rocketchat/rocket.chat as a default
|
|
Contributor
Author
|
@geekgonecrazy Can you merge this? This makes the template more flexible without breaking the original functionality. |
geekgonecrazy
approved these changes
Apr 9, 2018
Contributor
|
Sorry for the delay. We had to get some documentation switched on the redhat side, but all should be good. Soon as it finishes the CI we can get this merged. Thanks for the PR and your patience! |
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Apr 16, 2018
* goalify: (42 commits) Add Reload as global object update setup script domain to subdomain to setup S3 bucket [OTHER] Post to redhat registries api when tagging new release (RocketChat#10414) add setting Goalify API Gateway and Goalify API Token update initialSetting script to seed 1 time only Fix and improve vietnamese translation (RocketChat#10397) Don't expose the 'settings' property on users to regular users via the rest api (RocketChat#10411) [FIX] Updated OpenShift Template to take an Image as a Param (RocketChat#9946) Use Node 8.9 for CI build Fix incoming integrations being able to trigger a new message with a GET if there is no script enabled (RocketChat#9576) Update allowed labels by the rocket.cat gh bot (RocketChat#10360) [FIX] Snaps installations are breaking on avatar requests Update PULL_REQUEST_TEMPLATE.md Bump version to 0.64.0-develop Bump version to 0.63.1 update dev apn key and cert Lower cased the first letter and removed unnecessary minus Fix: Incorrect French language usage for Disabled snap revert to 8.9.4 Update saml_utils.js ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the OpenShift templates so that they use ROCKETCHAT_IMAGE as a parameter. It defaults to
rocketchat/rocket.chatbut can be updated when you run the templateExample:
Not passing the parameter will just use the version on dockerhub
rocketchat/rocket.chat@RocketChat/core
Closes #9944