Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 10, 2025

ARCH-1878

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Removed a deprecated file-sending method for Livechat functionality as part of a major version update.

@juliajforesti juliajforesti added this to the 8.0.0 milestone Nov 10, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

🦋 Changeset detected

Latest commit: df41d77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

This PR removes the deprecated sendFileLivechatMessage method from the Rocket.Chat livechat server by deleting its Meteor.methods wrapper and DDP interface declaration. The underlying exported function remains intact. A changeset documents the major version bump and changelog entry.

Changes

Cohort / File(s) Summary
Deprecation Removal
.changeset/popular-items-smash.md
New changeset file documenting major version bump for @rocket.chat/meteor with changelog entry noting removal of deprecated sendFileLivechatMessage method
Method Removal
apps/meteor/app/livechat/server/methods/sendFileLivechatMessage.ts
Removed Meteor.methods wrapper exposing sendFileLivechatMessage as a DDP method and deleted its ServerMethods interface declaration; exported function logic remains unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single cohesive change targeting one deprecated method
  • Minimal file scope with straightforward deletions
  • Verify no existing callers directly invoke this as a Meteor method
  • Confirm function remains properly exported for any internal callers

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo
  • aleksandernsilva

Poem

🐰 Away with the old, deprecated and worn,
The sendFile method bids farewell at dawn,
Its wrapper removed with a tidy clean sweep,
While exports stay cozy, their promises to keep!
A rabbit's goodbye to legacy code

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing a deprecated method. It is specific, directly related to the changeset, and follows conventional commit format.
Linked Issues check ✅ Passed The pull request implements the removal of the deprecated sendFileLivechatMessage method as required by ARCH-1878, removing both the DDP method augmentation and the Meteor.methods wrapper while preserving the exported function.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective of removing the deprecated sendFileLivechatMessage method. The changeset file and method removal are within scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-sendFileLivechatMessage

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 750af59 and df41d77.

📒 Files selected for processing (2)
  • .changeset/popular-items-smash.md (1 hunks)
  • apps/meteor/app/livechat/server/methods/sendFileLivechatMessage.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/meteor/app/livechat/server/methods/sendFileLivechatMessage.ts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • .changeset/popular-items-smash.md
🔇 Additional comments (1)
.changeset/popular-items-smash.md (1)

1-5: Changeset format and version bump are appropriate.

The changeset correctly documents a major version bump for removing the deprecated sendFileLivechatMessage API method, which aligns with Rocket.Chat v8.0.0 removals to simplify the codebase. The method was previously deprecated with a warning in v7.12.0, so this removal follows a proper deprecation lifecycle.

However, I cannot fully verify the implementation details (Meteor.methods wrapper removal, DDP interface updates, retained exports) without access to the actual code changes in apps/meteor/app/livechat/server/methods/sendFileLivechatMessage.ts referenced in the AI summary.

Could you provide the code file(s) being changed so I can verify:

  1. The Meteor.methods wrapper and ServerMethods interface were properly removed
  2. The exported function remains intact for backward compatibility
  3. All related imports/references were cleaned up

Alternatively, I can generate a verification script to inspect the repository if you'd like me to proceed with automated checks.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.44%. Comparing base (750af59) to head (df41d77).
⚠️ Report is 3 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37463      +/-   ##
=================================================
- Coverage          68.44%   68.44%   -0.01%     
=================================================
  Files               2877     2877              
  Lines             101867   101934      +67     
  Branches           17812    17728      -84     
=================================================
+ Hits               69727    69764      +37     
- Misses             30493    30522      +29     
- Partials            1647     1648       +1     
Flag Coverage Δ
unit 72.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review November 10, 2025 14:40
@juliajforesti juliajforesti requested a review from a team as a code owner November 10, 2025 14:40
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 10, 2025
@ggazzo ggazzo merged commit 6f88c06 into release-8.0.0 Nov 10, 2025
54 checks passed
@ggazzo ggazzo deleted the chore/remove-sendFileLivechatMessage branch November 10, 2025 17:13
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants