Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 10, 2025

ARCH-1876

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Revert
    • Removed the deprecated livechat:saveUnit method as part of this major release. Applications currently using this method will require migration to alternative approaches.

@juliajforesti juliajforesti added this to the 8.0.0 milestone Nov 10, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

🦋 Changeset detected

Latest commit: 8a5703e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

This PR removes the deprecated livechat:saveUnit Meteor server method from the livechat-enterprise module. The removal includes deleting the method implementation file, eliminating the corresponding import, and adding a changeset documenting the removal as part of a major release.

Changes

Cohort / File(s) Change Summary
Changeset Documentation
\.changeset/cyan-mayflies-juggle.md
Documents major version bump with removal of deprecated livechat:saveUnit method
Method Registration Cleanup
apps/meteor/ee/app/livechat-enterprise/server/index.ts
Removed import statement for ./methods/saveUnit module
Method Implementation Deletion
apps/meteor/ee/app/livechat-enterprise/server/methods/saveUnit.ts
Deleted entire file containing deprecated livechat:saveUnit Meteor method implementation, including method registration, deprecation logging, permission checks, and delegation to LivechatEnterprise.saveUnit

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward removal of deprecated code with no replacement logic
  • Changes are consistent deletions across related files
  • No conditional logic or complex refactoring to evaluate

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo
  • dougfabris
  • MarteinSchoeler

Poem

🐰 A method deprecated, now laid to rest,
The cleanup removes what once was blessed,
No longer shall saveUnit call,
A cleaner codebase, best of all! 🌙

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore!: remove deprecated livechat:saveUnit method' clearly and specifically describes the main change: removing a deprecated method.
Linked Issues check ✅ Passed The changeset removes the deprecated livechat:saveUnit method as indicated by the linked issue ARCH-1876, eliminating the method registration and its implementation.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the deprecated livechat:saveUnit method; no unrelated modifications are present in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-saveUnit

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 750af59 and 8a5703e.

📒 Files selected for processing (3)
  • .changeset/cyan-mayflies-juggle.md (1 hunks)
  • apps/meteor/ee/app/livechat-enterprise/server/index.ts (0 hunks)
  • apps/meteor/ee/app/livechat-enterprise/server/methods/saveUnit.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • apps/meteor/ee/app/livechat-enterprise/server/index.ts
  • apps/meteor/ee/app/livechat-enterprise/server/methods/saveUnit.ts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • .changeset/cyan-mayflies-juggle.md
🔇 Additional comments (1)
.changeset/cyan-mayflies-juggle.md (1)

1-5: LGTM!

The changeset is correctly formatted and appropriately documents the removal of the deprecated livechat:saveUnit method. The major version bump correctly reflects the breaking change for the removal, and aligns with the PR title's chore! indicator.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.92%. Comparing base (750af59) to head (8a5703e).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37461      +/-   ##
=================================================
+ Coverage          68.44%   70.92%   +2.47%     
=================================================
  Files               2877     3035     +158     
  Lines             101867   104621    +2754     
  Branches           17812    18435     +623     
=================================================
+ Hits               69727    74198    +4471     
+ Misses             30493    28478    -2015     
- Partials            1647     1945     +298     
Flag Coverage Δ
e2e 58.08% <ø> (+9.19%) ⬆️
unit 72.24% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review November 10, 2025 16:09
@juliajforesti juliajforesti requested a review from a team as a code owner November 10, 2025 16:09
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 10, 2025
@ggazzo ggazzo merged commit ae34ff0 into release-8.0.0 Nov 10, 2025
92 of 95 checks passed
@ggazzo ggazzo deleted the chore/remove-saveUnit branch November 10, 2025 16:12
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants