Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 5, 2025

ARCH-1859

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Release Notes

  • Breaking Changes
    • Removed the deprecated livechat:removeRoom method — integrations or scripts calling this method will need updates.
    • Major version bump for @rocket.chat/meteor.

@juliajforesti juliajforesti added this to the 8.0.0 milestone Nov 5, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: 63cf607

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removes the deprecated livechat:removeRoom Meteor method: deletes its server implementation file, removes its import from server bootstrap, and adds a changeset declaring a major version bump for @rocket.chat/meteor.

Changes

Cohort / File(s) Summary
Changeset Documentation
.changeset/plenty-flowers-help.md
New changeset file declaring a major version bump for @rocket.chat/meteor and noting removal of the deprecated livechat:removeRoom method
Server Initialization
apps/meteor/app/livechat/server/index.ts
Removed import of the removeRoom method module from the server bootstrap
Deprecated Method Removal
apps/meteor/app/livechat/server/methods/removeRoom.ts
Deleted file that registered the livechat:removeRoom Meteor method, its ServerMethods augmentation, permission and validation checks, and invocation of removeOmnichannelRoom

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant DDP as Meteor DDP
  participant Server as Livechat Server
  participant Backend as Omnichannel Removal

  Note over Client,DDP: OLD (removed in this PR)
  Client->>DDP: call "livechat:removeRoom"(rid)
  DDP->>Server: invoke Meteor method
  Server->>Backend: removeOmnichannelRoom(rid)
  Backend-->>Server: removal result
  Server-->>DDP: return result
  DDP-->>Client: response

  rect `#f8f9fa`
    Note right of Client: After this PR the DDP method path is removed
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check for any remaining references to livechat:removeRoom across the repo (clients, tests, packages).
  • Verify that CI/tests cover removal or that replacement endpoints (if present elsewhere) are used instead.

Possibly related PRs

Suggested reviewers

  • MartinSchoeler
  • KevLehman
  • dougfabris
  • sampaiodiego

Poem

🐰 I hopped through code and said "adieu",

The old removeRoom hid from view.
A changeset notes the final drum—
Farewell method, run on, scurry some! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing the deprecated livechat:removeRoom method. It is concise, uses the breaking change notation (chore!), and accurately summarizes the primary objective.
Linked Issues check ✅ Passed The code changes fully comply with the linked issue ARCH-1859. The pull request removes the livechat:removeRoom method entirely, including its server-side implementation, method registration, interface augmentation, and import references.
Out of Scope Changes check ✅ Passed All changes are directly scoped to removing the deprecated livechat:removeRoom method: the changeset document, removal from index imports, and deletion of the implementation file. No unrelated modifications are present.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a1c8379 and 63cf607.

📒 Files selected for processing (3)
  • .changeset/plenty-flowers-help.md (1 hunks)
  • apps/meteor/app/livechat/server/index.ts (0 hunks)
  • apps/meteor/app/livechat/server/methods/removeRoom.ts (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@juliajforesti juliajforesti changed the title chore!: remove deprecated livechat:removeRoom method chore!: remove deprecated livechat:removeRoom method Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.92%. Comparing base (3c42f0d) to head (a1c8379).
⚠️ Report is 389 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37391      +/-   ##
=================================================
+ Coverage          66.43%   70.92%   +4.48%     
=================================================
  Files               3276     3031     -245     
  Lines             109596   104339    -5257     
  Branches           20860    18374    -2486     
=================================================
+ Hits               72814    74006    +1192     
+ Misses             34116    28400    -5716     
+ Partials            2666     1933     -733     
Flag Coverage Δ
e2e 58.06% <ø> (+0.21%) ⬆️
e2e-api ?
unit 72.28% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review November 5, 2025 20:00
@juliajforesti juliajforesti requested a review from a team as a code owner November 5, 2025 20:00
@ggazzo ggazzo requested review from a team as code owners November 5, 2025 20:22
@ggazzo ggazzo force-pushed the release-8.0.0 branch 2 times, most recently from ae7b8da to 8728dd6 Compare November 5, 2025 20:57
@ggazzo ggazzo force-pushed the chore/remove-removeRoom branch from a1c8379 to 63cf607 Compare November 5, 2025 22:34
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 5, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 5, 2025
@ggazzo ggazzo merged commit ba732f5 into release-8.0.0 Nov 5, 2025
7 of 9 checks passed
@ggazzo ggazzo deleted the chore/remove-removeRoom branch November 5, 2025 22:35
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants