-
Notifications
You must be signed in to change notification settings - Fork 13k
chore!: remove deprecated livechat:removeRoom method
#37391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 63cf607 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughRemoves the deprecated Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant DDP as Meteor DDP
participant Server as Livechat Server
participant Backend as Omnichannel Removal
Note over Client,DDP: OLD (removed in this PR)
Client->>DDP: call "livechat:removeRoom"(rid)
DDP->>Server: invoke Meteor method
Server->>Backend: removeOmnichannelRoom(rid)
Backend-->>Server: removal result
Server-->>DDP: return result
DDP-->>Client: response
rect `#f8f9fa`
Note right of Client: After this PR the DDP method path is removed
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
livechat:removeRoom method
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #37391 +/- ##
=================================================
+ Coverage 66.43% 70.92% +4.48%
=================================================
Files 3276 3031 -245
Lines 109596 104339 -5257
Branches 20860 18374 -2486
=================================================
+ Hits 72814 74006 +1192
+ Misses 34116 28400 -5716
+ Partials 2666 1933 -733
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ae7b8da to
8728dd6
Compare
a1c8379 to
63cf607
Compare
ARCH-1859
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Release Notes